Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314263: Signed jars triggering Logger finder recursion and StackOverflowError #1756

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 20, 2023

I backport this for parity with 17.0.10-oracle.

I resolved a copyright and an import statement.
I include follow up test fix JDK-8315696 and JDK-8316087.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8314263 needs maintainer approval
  • JDK-8316087 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315696 needs maintainer approval

Issues

  • JDK-8314263: Signed jars triggering Logger finder recursion and StackOverflowError (Bug - P2 - Approved)
  • JDK-8315696: SignedLoggerFinderTest.java test failed (Bug - P3 - Approved)
  • JDK-8316087: Test SignedLoggerFinderTest.java is still failing (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1756/head:pull/1756
$ git checkout pull/1756

Update a local copy of the PR:
$ git checkout pull/1756
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1756

View PR using the GUI difftool:
$ git pr show -t 1756

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1756.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the title Goetz backport 8314263 Backport 7daae1fb4267f92b38f0152611d69b7b89691087 Sep 20, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Sep 20, 2023

/issue JDK-8315696

@openjdk openjdk bot changed the title Backport 7daae1fb4267f92b38f0152611d69b7b89691087 8314263: Signed jars triggering Logger finder recursion and StackOverflowError Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@GoeLin
Adding additional issue to issue list: 8315696: SignedLoggerFinderTest.java test failed.

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@GoeLin
Copy link
Member Author

GoeLin commented Sep 20, 2023

/issue JDK-8316087

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@GoeLin
Adding additional issue to issue list: 8316087: Test SignedLoggerFinderTest.java is still failing.

@mlbridge
Copy link

mlbridge bot commented Sep 20, 2023

Webrevs

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Sep 21, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314263: Signed jars triggering Logger finder recursion and StackOverflowError
8315696: SignedLoggerFinderTest.java test failed
8316087: Test SignedLoggerFinderTest.java is still failing

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 43ad5d2: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • 06756c4: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different
  • 6398e46: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
  • 4ebd8b3: 8311514: Incorrect regex in TestMetaSpaceLog.java
  • ac2d89b: 8311813: C1: Uninitialized PhiResolver::_loop field
  • 05964ff: 8315863: [GHA] Update checkout action to use v4
  • 875d24b: Merge
  • a831b7a: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • a06047a: 8168469: Memory leak in JceSecurity

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 22, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Sep 22, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

Going to push as commit 0e02204.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 069743d: 8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID
  • d6b1106: 8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails
  • 27c114f: 8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags
  • 3baaf7c: 8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags
  • 1eac8a4: 8271824: mark hotspot runtime/CompressedOops tests which ignore external VM flags
  • 43ad5d2: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • 06756c4: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different
  • 6398e46: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
  • 4ebd8b3: 8311514: Incorrect regex in TestMetaSpaceLog.java
  • ac2d89b: 8311813: C1: Uninitialized PhiResolver::_loop field
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/1a68e525f4f1e91634a1c387be1027e971e33649...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2023
@openjdk openjdk bot closed this Sep 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@GoeLin Pushed as commit 0e02204.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8314263 branch September 22, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants