Skip to content

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Mar 4, 2022

Hi all,

This backports a fix for a memory leak in the JDWP.
The original change applies cleanly:

openjdk/jdk@5ab22e8

See issue:
https://bugs.openjdk.java.net/browse/JDK-8276990
and original PR:
openjdk/jdk#7306

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/192/head:pull/192
$ git checkout pull/192

Update a local copy of the PR:
$ git checkout pull/192
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/192/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 192

View PR using the GUI difftool:
$ git pr show -t 192

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/192.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2022

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 4, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor

Seems like Skara doesn't recognize this PR as backport. I suggest to change the title to "Backport 5ab22e88da8d79f9e19e8afffdd06206f42bab94" and let the Skara bot do the necessary updates.

@rkennke rkennke changed the title 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations Backport 5ab22e88da8d79f9e19e8afffdd06206f42bab94 Mar 7, 2022
@openjdk openjdk bot changed the title Backport 5ab22e88da8d79f9e19e8afffdd06206f42bab94 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations Mar 7, 2022
@openjdk
Copy link

openjdk bot commented Mar 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 7, 2022
@openjdk
Copy link

openjdk bot commented Mar 7, 2022

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 91e9344: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed
  • ec2c521: 8278796: Incorrect behavior of FloatVector.withLane on X86
  • b3aa42d: 8278014: [vectorapi] Remove test run script
  • 47723c2: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • 1fc280c: 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN
  • 3aa5b51: 8273804: Platform.isTieredSupported should handle the no-compiler case
  • a51a5f0: 8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 7, 2022
@rkennke
Copy link
Contributor Author

rkennke commented Mar 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 8, 2022

Going to push as commit e2103de.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 91e9344: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed
  • ec2c521: 8278796: Incorrect behavior of FloatVector.withLane on X86
  • b3aa42d: 8278014: [vectorapi] Remove test run script
  • 47723c2: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • 1fc280c: 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN
  • 3aa5b51: 8273804: Platform.isTieredSupported should handle the no-compiler case
  • a51a5f0: 8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 8, 2022
@openjdk openjdk bot closed this Mar 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2022
@openjdk
Copy link

openjdk bot commented Mar 8, 2022

@rkennke Pushed as commit e2103de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants