8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only"

[GoeLin]

I want to backport this to fix the regression brought to 17.0.11 by JDK-8288663.

We saw three failures of jdk/jfr/startupargs/TestMemoryOptions.java since Nov 23 in our CI because of this.
assert(ms < 1000) failed: Un-interruptable sleep, short time use only

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8288846 needs maintainer approval

Issue

• JDK-8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only" (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2219/head:pull/2219
$ git checkout pull/2219

Update a local copy of the PR:
$ git checkout pull/2219
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2219/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2219

View PR using the GUI difftool:
$ git pr show -t 2219

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2219.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (30b23484)

[tstuefe]

But JDK-8292592 is not even in jdk 17?

[GoeLin]

Sorry I meant 8288663. Fixed.
The situation is a bit confusing as Markus Grönlund mentions a backport JBS issue. This was linked to this follow up.
I think this is also the reason the follow up was missed when 8288663 was backported.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• e8f7eae: 8321408: Add Certainly roots R1 and E1
• 4701c03: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit ab1e3cf.
Since your change was applied there have been 3 commits pushed to the master branch:

• f4fd2cb: 8290041: ModuleDescriptor.hashCode is inconsistent
• e8f7eae: 8321408: Add Certainly roots R1 and E1
• 4701c03: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit ab1e3cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.