8269914: Factor out heap printing for G1 young and full gc

[GoeLin]

I backport this as prerequisite for 8291753 as proposed before in #1900.
The backport has been tested by releaseing it in SapMachine in 17.0.10. This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle.

Also, this will bring G1 code of 17 closer to head probably simplifying further backports.

This change solves two JBS issue, so I need approval for two.

Some simple resolves needed:

src/hotspot/share/gc/g1/g1CollectedHeap.cpp
Basically trivial resolve due to context. One of the calls removed
in the original change is not in 17.
The patch brings a call to _g1h->rem_set()->print_coarsen_stats()
which is not available in 17. I uncommented this call to make
it build.

src/hotspot/share/gc/g1/g1FullGCScope.cpp
Trivial resolve.
Removes a destructor that calls several routines.
The destructor in 17 has one addtitional call that remains after removing the same ones as in the
original change. Thus I kept the destructor with this single call.
To make it build, I need to also keep the declaration of the destructor in the .hpp file.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8269914 needs maintainer approval
• JDK-8270018 needs maintainer approval

Issues

• JDK-8269914: Factor out heap printing for G1 young and full gc (Enhancement - P4 - Approved)
• JDK-8270018: Add scoped object for g1 young gc JFR notification (Enhancement - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2250/head:pull/2250
$ git checkout pull/2250

Update a local copy of the PR:
$ git checkout pull/2250
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2250

View PR using the GUI difftool:
$ git pr show -t 2250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2250.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[mlbridge]

Webrevs

• 00: Full (b68d1c6f)

[GoeLin]

GHA failure: Risc-V build failed. Seen in other PRs, too. Unrelated.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269914: Factor out heap printing for G1 young and full gc
8270018: Add scoped object for g1 young gc JFR notification

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 85a49ed: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name
• 2b34eeb: 8325496: Make TrimNativeHeapInterval a product switch
• 5687c5a: 8325213: Flags introduced by configure script are not passed to ADLC build
• 204ec8a: 8323717: Introduce test keyword for tests that need external dependencies

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 0052ab7.
Since your change was applied there have been 4 commits pushed to the master branch:

• 85a49ed: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name
• 2b34eeb: 8325496: Make TrimNativeHeapInterval a product switch
• 5687c5a: 8325213: Flags introduced by configure script are not passed to ADLC build
• 204ec8a: 8323717: Introduce test keyword for tests that need external dependencies

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 0052ab7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.