Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 17, 2022

I backport this for parity with 17.0.4-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276796: gc/TestSystemGC.java large pages subtest fails with ZGC

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/261/head:pull/261
$ git checkout pull/261

Update a local copy of the PR:
$ git checkout pull/261
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/261/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 261

View PR using the GUI difftool:
$ git pr show -t 261

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/261.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 91bb0d658bce010e74b248b56f0fa5b8a79e8802 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276796: gc/TestSystemGC.java large pages subtest fails with ZGC

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 18, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 18, 2022

Going to push as commit 32148d2.
Since your change was applied there has been 1 commit pushed to the master branch:

  • fbe05ec: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 18, 2022
@openjdk openjdk bot closed this Mar 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2022
@openjdk
Copy link

openjdk bot commented Mar 18, 2022

@GoeLin Pushed as commit 32148d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8276796 branch March 18, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant