Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274795: AArch64: avoid spilling and restoring r18 in macro assembler #28

Closed
wants to merge 1 commit into from

Conversation

lewurm
Copy link
Member

@lewurm lewurm commented Dec 22, 2021

Hi all,

This pull request contains a backport of commit ede3f4e9 from the openjdk/jdk repository.

The commit being backported was authored by Bernhard Urban-Forster on 14 Oct 2021 and was reviewed by Andrew Haley.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274795: AArch64: avoid spilling and restoring r18 in macro assembler

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/28/head:pull/28
$ git checkout pull/28

Update a local copy of the PR:
$ git checkout pull/28
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/28/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28

View PR using the GUI difftool:
$ git pr show -t 28

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/28.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 22, 2021

👋 Welcome back burban! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ede3f4e94c752a8457b7c24e001bd122845d2f6a 8274795: AArch64: avoid spilling and restoring r18 in macro assembler Dec 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2021

@lewurm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274795: AArch64: avoid spilling and restoring r18 in macro assembler

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • d8a22d6: 8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad
  • 81cd594: 8276314: [JVMCI] check alignment of call displacement during code installation
  • 9d0bfe1: 8265150: AsyncGetCallTrace crashes on ResourceMark
  • 93234a4: 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Dec 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 22, 2021

Webrevs

@lewurm
Copy link
Member Author

@lewurm lewurm commented Dec 28, 2021

@VladimirKempik do you think this is good to go?

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Dec 28, 2021

it's clean backport ( has labels "clean" and "ready") you don't need a review for this. Just put the labels on the bug and mention it's clean BP
Update: you already have all the needed labels, just /integrate

@lewurm
Copy link
Member Author

@lewurm lewurm commented Dec 28, 2021

/integrate

@openjdk openjdk bot added the sponsor label Dec 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 28, 2021

@lewurm
Your change (at version 87de249) is now ready to be sponsored by a Committer.

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Dec 28, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 28, 2021

Going to push as commit 5287dae.
Since your change was applied there have been 4 commits pushed to the master branch:

  • d8a22d6: 8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad
  • 81cd594: 8276314: [JVMCI] check alignment of call displacement during code installation
  • 9d0bfe1: 8265150: AsyncGetCallTrace crashes on ResourceMark
  • 93234a4: 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 28, 2021
@openjdk openjdk bot closed this Dec 28, 2021
@openjdk openjdk bot removed ready rfr sponsor labels Dec 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 28, 2021

@VladimirKempik @lewurm Pushed as commit 5287dae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
3 participants