8274795: AArch64: avoid spilling and restoring r18 in macro assembler

[lewurm]

Hi all,

This pull request contains a backport of commit ede3f4e9 from the openjdk/jdk repository.

The commit being backported was authored by Bernhard Urban-Forster on 14 Oct 2021 and was reviewed by Andrew Haley.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8274795: AArch64: avoid spilling and restoring r18 in macro assembler

Reviewers

• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/28/head:pull/28
$ git checkout pull/28

Update a local copy of the PR:
$ git checkout pull/28
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/28/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28

View PR using the GUI difftool:
$ git pr show -t 28

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/28.diff

[bridgekeeper]

👋 Welcome back burban! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@lewurm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274795: AArch64: avoid spilling and restoring r18 in macro assembler

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• d8a22d6: 8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad
• 81cd594: 8276314: [JVMCI] check alignment of call displacement during code installation
• 9d0bfe1: 8265150: AsyncGetCallTrace crashes on ResourceMark
• 93234a4: 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (87de2491)

[lewurm]

@VladimirKempik do you think this is good to go?

[VladimirKempik]

it's clean backport ( has labels "clean" and "ready") you don't need a review for this. Just put the labels on the bug and mention it's clean BP
Update: you already have all the needed labels, just /integrate

[lewurm]

/integrate

[openjdk]

@lewurm
Your change (at version 87de249) is now ready to be sponsored by a Committer.

[VladimirKempik]

/sponsor

[openjdk]

Going to push as commit 5287dae.
Since your change was applied there have been 4 commits pushed to the master branch:

• d8a22d6: 8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad
• 81cd594: 8276314: [JVMCI] check alignment of call displacement during code installation
• 9d0bfe1: 8265150: AsyncGetCallTrace crashes on ResourceMark
• 93234a4: 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"

Your commit was automatically rebased without conflicts.

[openjdk]

@VladimirKempik @lewurm Pushed as commit 5287dae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.