8316696: Remove the testing base classes: IntlTest and CollatorTest

[GoeLin]

I backport this for parity with 17.0.15-oracle.

Several enhancements touched the files edited in this change
causing the need to resolve. Among others:
8283698: Refactor Locale constructors used in src/test
8287868: Localized names update in COMPAT locale provider
Several tests needed resolving of Copyright. I omit those in the
following list.

test/jdk/java/text/BreakIterator/BreakIteratorTest.java
Two of the modified tests not in 17.

test/jdk/java/text/Collator/APITest.java
test/jdk/java/text/Format/DateFormat/DateFormatTest.java
I had to edit the quite different test output, but changes trivial.

test/jdk/java/text/Format/NumberFormat/Bug4838107.java
Later change "8317372: Refactor some NumberFormat tests to use JUnit" was already backported
including some lines of this change.

test/jdk/java/text/Format/NumberFormat/IntlTestDecimalFormatSymbols.java
19 added enhancement "8282625: Formatter caches Locale/DecimalFormatSymbols poorly"
I had to edit the quite different test output, but changes trivial.

test/jdk/java/util/Locale/LegacyCodesClassInvariant.java
This includes a bit of test rework I had to resolve, but the changed
code is identical to 21. The resolve is needed becuase of context
differences.

test/jdk/java/util/Locale/LocaleEnhanceTest.java
test/jdk/java/util/Locale/LocaleTest.java
These needed mostly trivial edits.

test/jdk/java/util/TimeZone/TimeZoneTest.java
Resolved as "8285844: TimeZone.getTimeZone(ZoneOffset) does not work for all
ZoneOffsets and returns GMT unexpected" not in 17.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8316696 needs maintainer approval

Issue

• JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest (Bug - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3214/head:pull/3214
$ git checkout pull/3214

Update a local copy of the PR:
$ git checkout pull/3214
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3214/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3214

View PR using the GUI difftool:
$ git pr show -t 3214

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3214.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316696: Remove the testing base classes: IntlTest and CollatorTest

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 9db8d28: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754
• 18f7669: 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information
• 6a5aaaa: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
• 2b8c19a: 8309740: Expand timeout windows for tests in JDK-8179502
• 25c7a7b: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts
• df6014e: 8346887: DrawFocusRect() may cause an assertion failure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (5dba2d43)
• 01: Full - Incremental (913d4553)
• 00: Full (0a66b43c)

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[TheRealMDoerr]

LGTM. Thanks for the explanations.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 2d29e1b.
Since your change was applied there have been 6 commits pushed to the master branch:

• 9db8d28: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754
• 18f7669: 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information
• 6a5aaaa: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
• 2b8c19a: 8309740: Expand timeout windows for tests in JDK-8179502
• 25c7a7b: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts
• df6014e: 8346887: DrawFocusRect() may cause an assertion failure

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 2d29e1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.