Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 18, 2025

I backport this for parity with 17.0.16-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328730 needs maintainer approval

Issue

  • JDK-8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3280/head:pull/3280
$ git checkout pull/3280

Update a local copy of the PR:
$ git checkout pull/3280
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3280/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3280

View PR using the GUI difftool:
$ git pr show -t 3280

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3280.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 18, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 18, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 86d5a0e: 6355567: AdobeMarkerSegment causes failure to read valid JPEG
  • 06ea6d5: 8347965: (tz) Update Timezone Data to 2025a

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 4047a3623a44d86df2b82565f33ce739a882802d 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main Feb 18, 2025
@openjdk
Copy link

openjdk bot commented Feb 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 18, 2025
@openjdk
Copy link

openjdk bot commented Feb 18, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 18, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 18, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 20, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Feb 20, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

Going to push as commit 9d2235b.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 5462825: 8292848: AWT_Mixing and TrayIcon tests fail on el8 with hard-coded isOel7
  • 86d5a0e: 6355567: AdobeMarkerSegment causes failure to read valid JPEG
  • 06ea6d5: 8347965: (tz) Update Timezone Data to 2025a

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 20, 2025
@openjdk openjdk bot closed this Feb 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 20, 2025
@openjdk
Copy link

openjdk bot commented Feb 20, 2025

@GoeLin Pushed as commit 9d2235b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant