Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 29, 2025

I backport this for parity with 17.0.17-oracle.

Clean backport, although skara would not grok it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8350964 needs maintainer approval

Issue

  • JDK-8350964: Add an ArtifactResolver.fetch(clazz) method (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3788/head:pull/3788
$ git checkout pull/3788

Update a local copy of the PR:
$ git checkout pull/3788
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3788/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3788

View PR using the GUI difftool:
$ git pr show -t 3788

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3788.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 29, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350964: Add an ArtifactResolver.fetch(clazz) method

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 4b2d777: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient
  • 01d92b5: 8343618: Stack smashing in awt_InputMethod.c on Linux s390x
  • 6a2ed7c: 8355249: Remove the use of WMIC from the entire source code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e60304ab52f36bcc85703bf8bc369f9e3ba04a80 8350964: Add an ArtifactResolver.fetch(clazz) method Jul 29, 2025
@openjdk
Copy link

openjdk bot commented Jul 29, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 29, 2025
@openjdk
Copy link

openjdk bot commented Jul 29, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 29, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 30, 2025

GHA failure unrelated:
Couldn't download https://httpredir.debian.org/debian/dists/bullseye/main/binary-s390x/Packages

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 30, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Aug 2, 2025

GHA failure: Infra issue, unrelated.
E: Couldn't download https://httpredir.debian.org/debian/dists/bullseye/main/binary-ppc64el/Packages

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 4, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Aug 4, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Aug 4, 2025

Going to push as commit 490cea3.
Since your change was applied there have been 6 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 4, 2025
@openjdk openjdk bot closed this Aug 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 4, 2025
@openjdk
Copy link

openjdk bot commented Aug 4, 2025

@GoeLin Pushed as commit 490cea3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8350964 branch August 4, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant