Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 10, 2025

I backport this to improve testing in 17.


Progress

  • JDK-8343396 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343396: Use OperatingSystem, Architecture, and OSVersion in jpackage tests (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4034/head:pull/4034
$ git checkout pull/4034

Update a local copy of the PR:
$ git checkout pull/4034
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4034/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4034

View PR using the GUI difftool:
$ git pr show -t 4034

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4034.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport a63f501b9238c6aae81c2e39fcc1852652116780 8343396: Use OperatingSystem, Architecture, and OSVersion in jpackage tests Oct 10, 2025
@openjdk
Copy link

openjdk bot commented Oct 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 10, 2025
@openjdk
Copy link

openjdk bot commented Oct 10, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 10, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 13, 2025

jdk.internal.util.OperatingSystem not in 17.

@GoeLin GoeLin closed this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant