Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 15, 2025

I backport this for parity with 17.0.18-oracle.

Resolved EventNames.java, probably clean anyways.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8291733 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291733: Remove JFR events that expose hashtable (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4047/head:pull/4047
$ git checkout pull/4047

Update a local copy of the PR:
$ git checkout pull/4047
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4047/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4047

View PR using the GUI difftool:
$ git pr show -t 4047

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4047.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport b7d2bde8e37817e827e685bd675b075c1f29b4c2 8291733: Remove JFR events that expose hashtable Oct 15, 2025
@openjdk
Copy link

openjdk bot commented Oct 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 15, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2025

Webrevs

@egahlin
Copy link
Member

egahlin commented Oct 16, 2025

Sorry about this. Oracle plans to back out the removal of these events, as the enhancement backport was a mistake. Instead, the events will be disabled in default.jfc, which is much less intrusive but still prevents excessive overhead in the out-of-the-box configuration.

In other words, only make this change:

diff --git a/src/jdk.jfr/share/conf/jfr/default.jfc b/src/jdk.jfr/share/conf/jfr/default.jfc
index 6faba56991c..6b5659a24b0 100644
--- a/src/jdk.jfr/share/conf/jfr/default.jfc
+++ b/src/jdk.jfr/share/conf/jfr/default.jfc
@@ -38,17 +38,17 @@
     </event>
 
     <event name="jdk.PlaceholderTableStatistics">
-      <setting name="enabled">true</setting>
+      <setting name="enabled">false</setting>
       <setting name="period">10 s</setting>
     </event>
 
     <event name="jdk.LoaderConstraintsTableStatistics">
-      <setting name="enabled">true</setting>
+      <setting name="enabled">false</setting>
       <setting name="period">10 s</setting>
     </event>
 
     <event name="jdk.ProtectionDomainCacheTableStatistics">
-      <setting name="enabled">true</setting>
+      <setting name="enabled">false</setting>
       <setting name="period">10 s</setting>
     </event>
 

@GoeLin
Copy link
Member Author

GoeLin commented Oct 16, 2025

Thanks for the patch above!

@GoeLin GoeLin closed this Oct 16, 2025
@GoeLin GoeLin deleted the goetz_backport_8291733 branch October 16, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants