-
Notifications
You must be signed in to change notification settings - Fork 232
8303089: [jittester] Add time limit to IRTree generation #4050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
@satyenme This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport of JDK-8303089: [jittester] Add time limit to IRTree generation Motivation: With this change, we make test more consistently reliable and practical to test. Only changes test code, so minimal risk. Change will bring openjdk closer to matching oracle. Risk: Low. Ran GHA Sanity Checks and new manual tests. Patch is clean. Change has been present since Feb 2023. Change has been accepted by Oracle. |
/integrate |
Going to push as commit 105c486.
Your commit was automatically rebased without conflicts. |
Backporting JDK-8303089: [jittester] Add time limit to IRTree generation. Adds a time limit (defaults to 10 minutes) to the generation of a single test in jittester's Automatic.java. Ran GHA Sanity Checks and new tests directly. Patch is clean. Backporting for parity with Oracle.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4050/head:pull/4050
$ git checkout pull/4050
Update a local copy of the PR:
$ git checkout pull/4050
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4050/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4050
View PR using the GUI difftool:
$ git pr show -t 4050
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4050.diff
Using Webrev
Link to Webrev Comment