Skip to content

Conversation

rgithubli
Copy link
Contributor

@rgithubli rgithubli commented Oct 16, 2025

A clean backport for JDK-8333783.

Backport for parity with oracle. Stabilize test DirectIOTest.java. The test passed locally. Low risk - test changes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333783 needs maintainer approval

Issue

  • JDK-8333783: java/nio/channels/FileChannel/directio/DirectIOTest.java is unstable with AV software (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4052/head:pull/4052
$ git checkout pull/4052

Update a local copy of the PR:
$ git checkout pull/4052
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4052

View PR using the GUI difftool:
$ git pr show -t 4052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4052.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2025

👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2025

@rgithubli This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333783: java/nio/channels/FileChannel/directio/DirectIOTest.java is unstable with AV software

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 8c6d12250b524c0f4ee25dbbc6fe959581b7617b 8333783: java/nio/channels/FileChannel/directio/DirectIOTest.java is unstable with AV software Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

⚠️ @rgithubli This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2025

Webrevs

@rgithubli
Copy link
Contributor Author

/approval request A clean backport for JDK-8333783.

Backport for parity with oracle. Stabilize test DirectIOTest.java. The test passed locally. Low risk - test changes.

@openjdk
Copy link

openjdk bot commented Oct 16, 2025

@rgithubli
8333783: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 16, 2025
@rgithubli
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 17, 2025
@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@rgithubli
Your change (at version 2a02f65) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

Going to push as commit 43f0cd9.
Since your change was applied there have been 7 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2025
@openjdk openjdk bot closed this Oct 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 17, 2025
@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@shipilev @rgithubli Pushed as commit 43f0cd9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants