8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

[GoeLin]

I would like to backport this to 17. This is a nice to have fix for jpackage, and it makes later backports more simple. Will also do the test follow-ups.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8281682 needs maintainer approval

Issue

• JDK-8281682: Redundant .ico files in Windows app-image cause unnecessary bloat (Enhancement - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4054/head:pull/4054
$ git checkout pull/4054

Update a local copy of the PR:
$ git checkout pull/4054
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4054/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4054

View PR using the GUI difftool:
$ git pr show -t 4054

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4054.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• ff97f22: 8339366: [jittester] Make it possible to generate tests without execution
• a63ed59: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java
• 43f0cd9: 8333783: java/nio/channels/FileChannel/directio/DirectIOTest.java is unstable with AV software
• ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/3a21a2741395ad9bfd5afb421e8a50b8ee769c11...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (a6426413)

[TheRealMDoerr]

Ok, AddLShortcutTest.java is not in 17u and the rest is clean. So, just don't forget the 3 follow-up fixes, please.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 5d06ac0.
Since your change was applied there have been 10 commits pushed to the master branch:

• ff97f22: 8339366: [jittester] Make it possible to generate tests without execution
• a63ed59: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java
• 43f0cd9: 8333783: java/nio/channels/FileChannel/directio/DirectIOTest.java is unstable with AV software
• ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/3a21a2741395ad9bfd5afb421e8a50b8ee769c11...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 5d06ac0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.