8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays

[GoeLin]

I backport this for parity with 17.0.18-oracle

I had to resolve many places due to nullptr differences.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8361447 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays (Bug - P3 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4056/head:pull/4056
$ git checkout pull/4056

Update a local copy of the PR:
$ git checkout pull/4056
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4056/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4056

View PR using the GUI difftool:
$ git pr show -t 4056

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4056.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• ff97f22: 8339366: [jittester] Make it possible to generate tests without execution
• a63ed59: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java
• 43f0cd9: 8333783: java/nio/channels/FileChannel/directio/DirectIOTest.java is unstable with AV software
• ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/3a21a2741395ad9bfd5afb421e8a50b8ee769c11...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (99a3727c)
• 00: Full (58607eaf)

[TheRealMDoerr]

I think the comment @param tag2 optional general purpose tag (see GuardedMemory::get_tag2()) should also be added before static void* wrap_copy.
Otherwise, LGTM.

[TheRealMDoerr]

Thanks!

[GoeLin]

I think the comment @param tag2 optional general purpose tag (see GuardedMemory::get_tag2()) should also be added before static void* wrap_copy. Otherwise, LGTM.

You are right, that is missing. fixed.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 9a19b3b.
Since your change was applied there have been 13 commits pushed to the master branch:

• 40381e1: 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"
• 91d7ef4: 8287401: jpackage tests failing on Windows due to powershell issue
• 5d06ac0: 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat
• ... and 10 more: https://git.openjdk.org/jdk17u-dev/compare/3a21a2741395ad9bfd5afb421e8a50b8ee769c11...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 9a19b3b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.