Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 16, 2025

I backport this as follow up of JDK-8281682.


Progress

  • JDK-8290557 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file" (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4059/head:pull/4059
$ git checkout pull/4059

Update a local copy of the PR:
$ git checkout pull/4059
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4059/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4059

View PR using the GUI difftool:
$ git pr show -t 4059

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4059.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/4057 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 7c3cfd13e3d67c185d15abb1c935853c856e8a42 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file" Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Oct 16, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Oct 17, 2025
@GoeLin GoeLin changed the base branch from pr/4057 to master October 18, 2025 17:17
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 18, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 18, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 18, 2025

Going to push as commit 40381e1.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 18, 2025
@openjdk openjdk bot closed this Oct 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 18, 2025
@openjdk
Copy link

openjdk bot commented Oct 18, 2025

@GoeLin Pushed as commit 40381e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8290557 branch October 18, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant