Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 16, 2025

I backport this for parity with 17.0.18-oracle


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333783 needs maintainer approval

Issue

  • JDK-8333783: java/nio/channels/FileChannel/directio/DirectIOTest.java is unstable with AV software (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4065/head:pull/4065
$ git checkout pull/4065

Update a local copy of the PR:
$ git checkout pull/4065
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4065/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4065

View PR using the GUI difftool:
$ git pr show -t 4065

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4065.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333783: java/nio/channels/FileChannel/directio/DirectIOTest.java is unstable with AV software

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 105c486: 8303089: [jittester] Add time limit to IRTree generation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 8c6d12250b524c0f4ee25dbbc6fe959581b7617b 8333783: java/nio/channels/FileChannel/directio/DirectIOTest.java is unstable with AV software Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2025

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 16, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 17, 2025

Rui Li also backported this.

@GoeLin GoeLin closed this Oct 17, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant