Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Oct 28, 2025

Backporting JDK-8357822: C2: Multiple string optimization tests are no longer testing string concatenation optimizations. Adds several tests for string concatenation optimization in C2. Ran GHA Sanity Checks (passed) and adjusted tests (passed). Patch is clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8357822 needs maintainer approval

Issue

  • JDK-8357822: C2: Multiple string optimization tests are no longer testing string concatenation optimizations (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4130/head:pull/4130
$ git checkout pull/4130

Update a local copy of the PR:
$ git checkout pull/4130
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4130

View PR using the GUI difftool:
$ git pr show -t 4130

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4130.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 28, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

Hi @rm-gh-8, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user rm-gh-8" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357822: C2: Multiple string optimization tests are no longer testing string concatenation optimizations

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 9449e0b: 8369450: [Ubuntu 25.10] openjdk fails to build due to rust-coreutils date
  • 9dbee30: 8325766: Extend CertificateBuilder to create trust and end entity certificates programmatically
  • 7fe2553: 8369226: GHA: Switch to MacOS 15

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 6c616c71ec9a8ee6e0203921deef20d09db39698 8357822: C2: Multiple string optimization tests are no longer testing string concatenation optimizations Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 28, 2025
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Oct 28, 2025

/covered

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Oct 28, 2025

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Oct 28, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Oct 29, 2025
@rm-gh-8 rm-gh-8 marked this pull request as ready for review November 5, 2025 17:30
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 5, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2025

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Nov 5, 2025

Merged in order to pull in GHA Sanity Check fix.

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Nov 5, 2025

/approval request for backport of JDK-8357822: C2: Multiple string optimization tests are no longer testing string concatenation optimizations.

Ran the updated tests as well as related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(All Passed) - make test TEST=hotspot/jtreg/compiler
(All Passed) - make test TEST=hotspot/jtreg/vmTestbase/vm/compiler/optimizations/stringconcat/implicit

Results are attached.

windows-x64-hotspot-vmtestbase-vm-compiler-optimizations-stringconcat-implicit.log
windows-x64-hotspot-compiler.log
linux-x64-hotspot-vmtestbase-vm-compiler-optimizations-stringconcat-implicit.log
linux-x64-hotspot-compiler.log
linux-aarch64-hotspot-vmtestbase-vm-compiler-optimizations-stringconcat-implicit.log
linux-aarch64-hotspot-compiler.log
macos-aarch64-hotspot-vmtestbase-vm-compiler-optimizations-stringconcat-implicit.log
macos-aarch64-hotspot-compiler.log

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@rm-gh-8
8357822: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 5, 2025
@shipilev
Copy link
Member

shipilev commented Nov 6, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@shipilev The change author (@rm-gh-8) must issue an integrate command before the integration can be sponsored.

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Nov 6, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 6, 2025
@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@rm-gh-8
Your change (at version afcf43c) is now ready to be sponsored by a Committer.

@Rudometov
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

Going to push as commit 943251d.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 9449e0b: 8369450: [Ubuntu 25.10] openjdk fails to build due to rust-coreutils date
  • 9dbee30: 8325766: Extend CertificateBuilder to create trust and end entity certificates programmatically
  • 7fe2553: 8369226: GHA: Switch to MacOS 15

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 6, 2025
@openjdk openjdk bot closed this Nov 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 6, 2025
@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@Rudometov @rm-gh-8 Pushed as commit 943251d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants