Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284686: Interval of < 1 ms disables ExecutionSample events #463

Conversation

parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Jun 13, 2022

Clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284686: Interval of < 1 ms disables ExecutionSample events

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/463/head:pull/463
$ git checkout pull/463

Update a local copy of the PR:
$ git checkout pull/463
$ git pull https://git.openjdk.org/jdk17u-dev pull/463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 463

View PR using the GUI difftool:
$ git pr show -t 463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/463.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2022

👋 Welcome back parttimenerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 13, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2022

Webrevs

@parttimenerd parttimenerd changed the title 8284686: Interval of < 1 ms disables ExecutionSample events Backport 902b1dd4550136c520e5ec6cb8c4fe9a81218938 Jun 14, 2022
@openjdk openjdk bot changed the title Backport 902b1dd4550136c520e5ec6cb8c4fe9a81218938 8284686: Interval of < 1 ms disables ExecutionSample events Jun 14, 2022
@openjdk
Copy link

openjdk bot commented Jun 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 14, 2022

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284686: Interval of < 1 ms disables ExecutionSample events

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f8d3d42: 8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)
  • dd7280f: 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 14, 2022
@parttimenerd
Copy link
Contributor Author

/integrate

@GoeLin
Copy link
Member

GoeLin commented Jun 14, 2022

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 14, 2022
@openjdk
Copy link

openjdk bot commented Jun 14, 2022

@parttimenerd
Your change (at version 3cb1d08) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Jun 14, 2022

Going to push as commit cb415a1.
Since your change was applied there have been 2 commits pushed to the master branch:

  • f8d3d42: 8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)
  • dd7280f: 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 14, 2022
@openjdk openjdk bot closed this Jun 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 14, 2022
@openjdk
Copy link

openjdk bot commented Jun 14, 2022

@GoeLin @parttimenerd Pushed as commit cb415a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants