Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277493: [REDO] Quarantined jpackage apps are labeled as "damaged" #576

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 21, 2022

I backport this for parity with 17.0.5-oracle.

Omitted patch to test/jdk/tools/jpackage/share/AppContentTest.java
which was added in 18 for new feature "8274346: Support for additional content in an app-image."

The rest of the backport is clean. Marking as /clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/576/head:pull/576
$ git checkout pull/576

Update a local copy of the PR:
$ git checkout pull/576
$ git pull https://git.openjdk.org/jdk17u-dev pull/576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 576

View PR using the GUI difftool:
$ git pr show -t 576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/576.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 273c7329e7dff6e97ffe5b299a6bbb5de8ea9190 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged" Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 21, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jul 21, 2022

/clean

@openjdk openjdk bot added the clean label Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 22, 2022

Pre-submit failure: TestMetaspacePerfCounters.java Known to be failing, unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Jul 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 23, 2022

Going to push as commit cfe1e95.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 6c53fad: 8282007: Assorted enhancements to jpackage testing framework
  • 930be90: 8278233: [macos] tools/jpackage tests timeout due to /usr/bin/osascript

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 23, 2022
@openjdk openjdk bot closed this Jul 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 23, 2022
@openjdk
Copy link

openjdk bot commented Jul 23, 2022

@GoeLin Pushed as commit cfe1e95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8277493 branch July 23, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants