-
Notifications
You must be signed in to change notification settings - Fork 231
8277493: [REDO] Quarantined jpackage apps are labeled as "damaged" #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
/clean |
|
@GoeLin This backport pull request is now marked as clean |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Pre-submit failure: TestMetaspacePerfCounters.java Known to be failing, unrelated. |
|
/integrate |
|
Going to push as commit cfe1e95.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.5-oracle.
Omitted patch to test/jdk/tools/jpackage/share/AppContentTest.java
which was added in 18 for new feature "8274346: Support for additional content in an app-image."
The rest of the backport is clean. Marking as /clean.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/576/head:pull/576$ git checkout pull/576Update a local copy of the PR:
$ git checkout pull/576$ git pull https://git.openjdk.org/jdk17u-dev pull/576/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 576View PR using the GUI difftool:
$ git pr show -t 576Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/576.diff