-
Notifications
You must be signed in to change notification settings - Fork 232
8282351: jpackage does not work if class file has $$ in the name on windows
#597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
$$ in the name on windows
|
This backport pull request has now been updated with issue from the original commit. |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Pre-submit failure: ant download failed. Unrelated. |
|
Thanks for the review! |
|
Going to push as commit cd6f659.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.5-oracle.
Progress
Issue
$$in the name on windowsReviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/597/head:pull/597$ git checkout pull/597Update a local copy of the PR:
$ git checkout pull/597$ git pull https://git.openjdk.org/jdk17u-dev pull/597/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 597View PR using the GUI difftool:
$ git pr show -t 597Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/597.diff