Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 25, 2022

I backport this for parity with 17.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282351: jpackage does not work if class file has $$ in the name on windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/597/head:pull/597
$ git checkout pull/597

Update a local copy of the PR:
$ git checkout pull/597
$ git pull https://git.openjdk.org/jdk17u-dev pull/597/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 597

View PR using the GUI difftool:
$ git pr show -t 597

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/597.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 29395534d9683a802364dc53610dee2b525fb032 8282351: jpackage does not work if class file has $$ in the name on windows Jul 25, 2022
@openjdk
Copy link

openjdk bot commented Jul 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 25, 2022
@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282351: jpackage does not work if class file has `$$` in the name on windows

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 26, 2022

Pre-submit failure: ant download failed. Unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Jul 28, 2022

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Jul 28, 2022

Going to push as commit cd6f659.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 37c9cd1: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test
  • 6fa5281: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows
  • 25ad9d6: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.
  • 98f6737: 8283911: DEFAULT_PROMOTED_VERSION_PRE not reset to 'ea' for jdk-17.0.4
  • 3b4649d: 7131823: bug in GIFImageReader
  • d489142: 8282860: Write a regression test for JDK-4164779
  • 612cca3: 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 28, 2022
@openjdk openjdk bot closed this Jul 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 28, 2022
@openjdk
Copy link

openjdk bot commented Jul 28, 2022

@GoeLin Pushed as commit cd6f659.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants