Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs #604

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 28, 2022

I backport this for parity with 17.0.5-oracle.

This change originally only fixes a test command (adding UnlockDiagnosticVMOptions)
But this test command was only added in "273456: Do not hold ttyLock around stack walking" in 18 which is not backported.

I think this only makes sense if the whole new test command is backported including the fix.
Test passes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/604/head:pull/604
$ git checkout pull/604

Update a local copy of the PR:
$ git checkout pull/604
$ git pull https://git.openjdk.org/jdk17u-dev pull/604/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 604

View PR using the GUI difftool:
$ git pr show -t 604

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/604.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 261cb44b13e5910180a2599ca756eb7ae6f9c443 8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs Jul 28, 2022
@openjdk
Copy link

openjdk bot commented Jul 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 28, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 29, 2022

Pre-submit test: the modified test fails. An assertion is raised. Will investigate.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2022

@GoeLin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2022

@GoeLin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Sep 23, 2022
@GoeLin GoeLin deleted the goetz_backport_8273629 branch November 4, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant