8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs #604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I backport this for parity with 17.0.5-oracle.
This change originally only fixes a test command (adding UnlockDiagnosticVMOptions)
But this test command was only added in "273456: Do not hold ttyLock around stack walking" in 18 which is not backported.
I think this only makes sense if the whole new test command is backported including the fix.
Test passes.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/604/head:pull/604
$ git checkout pull/604
Update a local copy of the PR:
$ git checkout pull/604
$ git pull https://git.openjdk.org/jdk17u-dev pull/604/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 604
View PR using the GUI difftool:
$ git pr show -t 604
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/604.diff