Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285730: unify _WIN32_WINNT settings #628

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 10, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/628/head:pull/628
$ git checkout pull/628

Update a local copy of the PR:
$ git checkout pull/628
$ git pull https://git.openjdk.org/jdk17u-dev pull/628/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 628

View PR using the GUI difftool:
$ git pr show -t 628

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/628.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 10, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4fd79a6ad2683e4863bd4e311cb01cbc30ebf57f 8285730: unify _WIN32_WINNT settings Aug 10, 2022
@openjdk
Copy link

openjdk bot commented Aug 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 10, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285730: unify _WIN32_WINNT settings

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 10, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 10, 2022

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 17, 2022

Going to push as commit e650bdc.
Since your change was applied there have been 6 commits pushed to the master branch:

  • cb294d9: 8289910: unify os::message_box across posix platforms
  • 92571e3: 8291633: Build failures with GCC 11, Alpine 3 due to incompatible casts from nullptr
  • 2c988d1: 8283903: GetContainerCpuLoad does not return the correct result in share mode
  • cf0abb8: Merge 'jdk17.0.4.1' into master
  • 02fa4be: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
  • 27057f8: 8292258: Bump update version for OpenJDK: jdk-17.0.4.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 17, 2022
@openjdk openjdk bot closed this Aug 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@MBaesken Pushed as commit e650bdc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant