New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274639: Provide a way to disable warnings for cross-modular links #723
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
@apavlyutkin This change is no longer ready for integration - check the PR body for details. |
Hi, |
CRS raised. The Pre-sumbit tests for macos-arm64 failed due to a network problem:
Thank you |
@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@apavlyutkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Hi! Here is backport of JDK-8274639. The patch adds the ability to disable Link Modularity Mismatch warnings and so projects using cross-modular links can be compiled with -Werror flag.
Original patch applied cleanly.
Verification (amd64/20.04LTS): test/langtools/jdk/javadoc/doclet/testLinkOption/TestLinkOptionWithModule.java
Regression (amd64/20.04LTS): test/langtools/jdk/javadoc
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/723/head:pull/723
$ git checkout pull/723
Update a local copy of the PR:
$ git checkout pull/723
$ git pull https://git.openjdk.org/jdk17u-dev pull/723/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 723
View PR using the GUI difftool:
$ git pr show -t 723
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/723.diff