Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274639: Provide a way to disable warnings for cross-modular links #723

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Sep 23, 2022

Hi! Here is backport of JDK-8274639. The patch adds the ability to disable Link Modularity Mismatch warnings and so projects using cross-modular links can be compiled with -Werror flag.

Original patch applied cleanly.

Verification (amd64/20.04LTS): test/langtools/jdk/javadoc/doclet/testLinkOption/TestLinkOptionWithModule.java
Regression (amd64/20.04LTS): test/langtools/jdk/javadoc


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8274639: Provide a way to disable warnings for cross-modular links
  • JDK-8294354: Provide a way to disable warnings for cross-modular links (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/723/head:pull/723
$ git checkout pull/723

Update a local copy of the PR:
$ git checkout pull/723
$ git pull https://git.openjdk.org/jdk17u-dev pull/723/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 723

View PR using the GUI difftool:
$ git pr show -t 723

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/723.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 103da8fae12a2aaff1a02a219690ce89fc098641 8274639: Provide a way to disable warnings for cross-modular links Sep 23, 2022
@openjdk
Copy link

openjdk bot commented Sep 23, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 23, 2022

@apavlyutkin This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Sep 26, 2022

Hi,
please first request a CSR for 17. See https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix in the bottom.
I'll remove the fix-request tag. please add it again once the CSR is approve.
Please also check why the Pre-submit tests are failing.
Thanks

@apavlyutkin
Copy link
Contributor Author

Hi, please first request a CSR for 17. See https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix in the bottom. I'll remove the fix-request tag. please add it again once the CSR is approve. Please also check why the Pre-submit tests are failing. Thanks

CRS raised. The Pre-sumbit tests for macos-arm64 failed due to a network problem:

[build.sh][INFO] Downloading https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to /Users/runner/work/jdk17u-dev/jdk17u-dev/jtreg/src/make/../build/deps/apache-ant-1.10.8-bin.zip
Error: sh][ERROR] wget exited with exit code 4

Thank you

@openjdk openjdk bot added csr Pull request needs approved CSR before integration and removed ready Pull request is ready to be integrated labels Sep 26, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2022

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2022

@apavlyutkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean csr Pull request needs approved CSR before integration rfr Pull request is ready for review
2 participants