-
Notifications
You must be signed in to change notification settings - Fork 231
8293998: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293998: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC #740
Conversation
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
phohensee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
|
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Thanks for the review! |
|
/integrate |
|
Going to push as commit 90cc8ac.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr Pushed as commit 90cc8ac. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8293998. Linux part applies cleanly modulo file renaming. AIX code was not yet available. I've taken the code from jdk head (part of JFR support JDK-8203290, but also needed for Forte Analyzer AsyncGetCallTrace). It's identical to the linux version except
uc_mcontextaccesses.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/740/head:pull/740$ git checkout pull/740Update a local copy of the PR:
$ git checkout pull/740$ git pull https://git.openjdk.org/jdk17u-dev pull/740/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 740View PR using the GUI difftool:
$ git pr show -t 740Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/740.diff