Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 27, 2022

Backport of JDK-8293998. Linux part applies cleanly modulo file renaming. AIX code was not yet available. I've taken the code from jdk head (part of JFR support JDK-8203290, but also needed for Forte Analyzer AsyncGetCallTrace). It's identical to the linux version except uc_mcontext accesses.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293998: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/740/head:pull/740
$ git checkout pull/740

Update a local copy of the PR:
$ git checkout pull/740
$ git pull https://git.openjdk.org/jdk17u-dev pull/740/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 740

View PR using the GUI difftool:
$ git pr show -t 740

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/740.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 14c6ac457d319a2e7f9cc9e7355c81c421a065dd 8293998: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC Sep 27, 2022
@openjdk
Copy link

openjdk bot commented Sep 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 27, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293998: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 461c6e8: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server"
  • 1b98800: 8289559: java/awt/a11y/AccessibleJPopupMenuTest.java test fails with java.lang.NullPointerException
  • 14d7e3c: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path
  • 7425564: 8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception
  • fa8feb4: 8290532: Adjust PKCS11Exception and handle more PKCS11 error codes
  • 4ea5526: 8282777: Create a Regression test for JDK-4515031
  • f49ffca: 8286772: java/awt/dnd/DropTargetInInternalFrameTest/DropTargetInInternalFrameTest.html times out and fails in Windows
  • ad9e9f2: 8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray
  • 79288de: 8285305: Create an automated test for JDK-4495286
  • 3461ff3: 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/0c551b6c01bed302a2fbd1271773c3e231920ddd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 29, 2022
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2022

Going to push as commit 90cc8ac.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 9483069: 8282528: AArch64: Incorrect replicate2L_zero rule
  • 67f31bb: 8293232: Fix race condition in pkcs11 SessionManager
  • 3bcdb66: 8293578: Duplicate ldc generated by javac
  • beb2ca2: 8283059: Uninitialized warning in check_code.c with GCC 11.2
  • 796628e: 8287076: Document.normalizeDocument() produces different results
  • 461c6e8: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server"
  • 1b98800: 8289559: java/awt/a11y/AccessibleJPopupMenuTest.java test fails with java.lang.NullPointerException
  • 14d7e3c: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path
  • 7425564: 8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception
  • fa8feb4: 8290532: Adjust PKCS11Exception and handle more PKCS11 error codes
  • ... and 13 more: https://git.openjdk.org/jdk17u-dev/compare/0c551b6c01bed302a2fbd1271773c3e231920ddd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2022
@openjdk openjdk bot closed this Oct 4, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 4, 2022
@TheRealMDoerr TheRealMDoerr deleted the 8293998_PPC64_JFR_last_Java_pc branch October 4, 2022 10:33
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 4, 2022
@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@TheRealMDoerr Pushed as commit 90cc8ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants