Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible" #83

Conversation

andrew-m-leonard
Copy link

@andrew-m-leonard andrew-m-leonard commented Jan 12, 2022

Backporting the [redo] reproducible ZipArchive.gmk fix to enable reproducible openjdk build src.zip files.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/83/head:pull/83
$ git checkout pull/83

Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/83/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 83

View PR using the GUI difftool:
$ git pr show -t 83

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/83.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2022

👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c93552c8bbcdabb6219327d67409bf63432f49d8 8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible" Jan 12, 2022
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@andrew-m-leonard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • d1d0b08: 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it
  • 3354244: 8271202: C1: assert(false) failed: live_in set of first block must be empty
  • e965881: 8263567: gtests don't terminate the VM safely
  • e92b2bc: 8269206: A small typo in comment in test/lib/sun/hotspot/WhiteBox.java
  • 84457e5: 8278309: [windows] use of uninitialized OSThread::_state
  • 78e2153: 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root
  • fc92adc: 8276764: Enable deterministic file content ordering for Jar and Jmod
  • 0130fdc: 8273967: gtest os.dll_address_to_function_and_library_name_vm fails on macOS12
  • 4b5b58d: 8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12
  • 3c279bd: 8277846: Implement fast-path for ASCII-compatible CharsetEncoders on ppc64
  • ... and 5 more: https://git.openjdk.java.net/jdk17u-dev/compare/8d7a6e5d4bc2bd3ad1078202a7f75e1f05e4a78c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2022

Webrevs

@andrew-m-leonard
Copy link
Author

andrew-m-leonard commented Jan 14, 2022

tier1 all good

@andrew-m-leonard
Copy link
Author

andrew-m-leonard commented Jan 17, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 17, 2022
@openjdk
Copy link

openjdk bot commented Jan 17, 2022

@andrew-m-leonard
Your change (at version fb3a662) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

RealCLanger commented Jan 17, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 17, 2022

Going to push as commit 2137e83.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 69d296d: 8279833: Loop optimization issue in String.encodeUTF8_UTF16
  • 6f644e0: 8273277: C2: Move conditional negation into rc_predicate
  • d1d0b08: 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it
  • 3354244: 8271202: C1: assert(false) failed: live_in set of first block must be empty
  • e965881: 8263567: gtests don't terminate the VM safely
  • e92b2bc: 8269206: A small typo in comment in test/lib/sun/hotspot/WhiteBox.java
  • 84457e5: 8278309: [windows] use of uninitialized OSThread::_state
  • 78e2153: 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root
  • fc92adc: 8276764: Enable deterministic file content ordering for Jar and Jmod
  • 0130fdc: 8273967: gtest os.dll_address_to_function_and_library_name_vm fails on macOS12
  • ... and 7 more: https://git.openjdk.java.net/jdk17u-dev/compare/8d7a6e5d4bc2bd3ad1078202a7f75e1f05e4a78c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2022
@openjdk openjdk bot closed this Jan 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 17, 2022
@openjdk
Copy link

openjdk bot commented Jan 17, 2022

@RealCLanger @andrew-m-leonard Pushed as commit 2137e83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andrew-m-leonard
Copy link
Author

andrew-m-leonard commented Jan 18, 2022

thank you Christoph @RealCLanger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants