Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Aug 19, 2021

Clean backport to improve testing UX.

Additional testing:

  • hotspot_gc_shenandoah passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8270094: Shenandoah: Provide human-readable labels for test configurations

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/29/head:pull/29
$ git checkout pull/29

Update a local copy of the PR:
$ git checkout pull/29
$ git pull https://git.openjdk.java.net/jdk17u pull/29/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29

View PR using the GUI difftool:
$ git pr show -t 29

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/29.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 676f1d76cab9108655f2ce462db321b975563eb7 8270094: Shenandoah: Provide human-readable labels for test configurations Aug 19, 2021
@openjdk
Copy link

openjdk bot commented Aug 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 19, 2021
@openjdk
Copy link

openjdk bot commented Aug 19, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270094: Shenandoah: Provide human-readable labels for test configurations

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 19, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 19, 2021

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 23, 2021

Going to push as commit 3c1023c.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 9554fba: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • bf920d9: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
  • 24e5c1a: 8272326: java/util/Random/RandomTestMoments.java had two Gaussian fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 23, 2021
@openjdk
Copy link

openjdk bot commented Aug 23, 2021

@shipilev Pushed as commit 3c1023c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant