-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318158: RISC-V: implement roundD/roundF intrinsics #161
Conversation
👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport, related only to RISC-V platform, to optimize performance in double/float rounding operations via intrinsics. |
@omikhaltsova |
@omikhaltsova This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 81 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ada400c.
Your commit was automatically rebased without conflicts. |
@omikhaltsova Pushed as commit ada400c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I would like to backport JDK-8318158 to jdk21u in order to optimize performance in double/float rounding operations by means of intrinsics.
The patch applied cleanly.
Tested: tier1 tests passed.
The benchmark shows the following performance improvement on the T-Head RVB-ICE board:
Before
After
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/161/head:pull/161
$ git checkout pull/161
Update a local copy of the PR:
$ git checkout pull/161
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/161/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 161
View PR using the GUI difftool:
$ git pr show -t 161
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/161.diff
Webrev
Link to Webrev Comment