Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented May 15, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312218 needs maintainer approval

Issue

  • JDK-8312218: Print additional debug information when hitting assert(in_hash) (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/572/head:pull/572
$ git checkout pull/572

Update a local copy of the PR:
$ git checkout pull/572
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/572/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 572

View PR using the GUI difftool:
$ git pr show -t 572

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/572.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 15, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312218: Print additional debug information when hitting assert(in_hash)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 0a2e2e7: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
  • 6b0467c: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
  • 87fe0d2: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • 9b8f988: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • 30f0779: 8331167: UBSan enabled build fails in adlc on macOS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7cbab1f39636f3cf32f1276bc46feaa8107a14e6 8312218: Print additional debug information when hitting assert(in_hash) May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 15, 2024
@mlbridge
Copy link

mlbridge bot commented May 15, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor

GHA test failure is unrelated. (Also seen in other PRs.)

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels May 16, 2024
@MBaesken
Copy link
Member Author

linux-x64 upload failure seems to be unrelated.

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 17, 2024

Going to push as commit f953b8a.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 0a2e2e7: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
  • 6b0467c: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
  • 87fe0d2: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • 9b8f988: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • 30f0779: 8331167: UBSan enabled build fails in adlc on macOS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2024
@openjdk openjdk bot closed this May 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

@MBaesken Pushed as commit f953b8a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants