8265019: Update tests for additional TestNG test permissions #469

zzambers · 2024-03-19T16:44:08Z

Backport fixes 2 tests failures, when newer jtreg is used (6+1). Affects only test code. It excludes changes to test/jdk/java/lang/ProcessHandle/PermissionTest.java as jdk8 does not have this file (ProcessHandle is jdk9+). Otherwise, when dealt with different paths, changeset applied cleanly (except for copyright line, which was done manually).

Fixed tests:

javax/sql/testng/test/rowset/spi/SyncFactoryPermissionsTests.java
java/sql/testng/test/sql/DriverManagerPermissionsTests.java

Exception:

java.security.AccessControlException: access denied ("java.util.PropertyPermission" "testng.thread.affinity" "read")
    at java.security.AccessControlContext.checkPermission(AccessControlContext.java:472)
    at java.security.AccessController.checkPermission(AccessController.java:886)
    at java.lang.SecurityManager.checkPermission(SecurityManager.java:549)
    at java.lang.SecurityManager.checkPropertyAccess(SecurityManager.java:1294)
    at java.lang.System.getProperty(System.java:769)
    at org.testng.internal.RuntimeBehavior.enforceThreadAffinity(RuntimeBehavior.java:106)
    at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
    at java.util.ArrayList.forEach(ArrayList.java:1259)
    at org.testng.TestRunner.privateRun(TestRunner.java:764)
    at org.testng.TestRunner.run(TestRunner.java:585)
    at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)
    at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)
    at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)
    at org.testng.SuiteRunner.run(SuiteRunner.java:286)
    at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
    at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
    at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218)
    at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
    at org.testng.TestNG.runSuites(TestNG.java:1069)
    at org.testng.TestNG.run(TestNG.java:1037)
    at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:94)
    at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:54)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
    at java.lang.Thread.run(Thread.java:750)

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8265019 needs maintainer approval

Issue

JDK-8265019: Update tests for additional TestNG test permissions (Bug - P3 - Approved)

Reviewers

Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/469/head:pull/469
$ git checkout pull/469

Update a local copy of the PR:
$ git checkout pull/469
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 469

View PR using the GUI difftool:
$ git pr show -t 469

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/469.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-03-19T16:44:26Z

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-19T16:45:01Z

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8265019: Update tests for additional TestNG test permissions

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 148 new commits pushed to the master branch:

3683a81: Merge
129290d: 8339180: Enhanced Building of Processes: Follow-on Issue
c2f7e61: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
2d042cf: 8336564: Enhance mask blit functionality redux
1a447c7: 8335428: Enhanced Building of Processes
1a6e3a5: 8342822: jdk8u432-b06 does not compile on AIX
5a4b440: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
d407d63: 8345504: Bump update version of OpenJDK: 8u452
2931b1d: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F
10122b5: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
... and 138 more: https://git.openjdk.org/jdk8u-dev/compare/147b4188bc0d260a401ba383103d20cb428dbb88...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-03-19T16:45:18Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2024-03-19T16:48:43Z

Webrevs

00: Full (493c2120)

zzambers · 2024-03-20T11:34:13Z

Testing:
GHA: OK (jdk/tier1 failures unrelated, see JDK-8324583, one hotspot/tier1 timeout error on linux/x86 unrelated)

locally tested tests in javax/sql and java/sql - OK (no failures)

bridgekeeper · 2024-04-17T12:25:56Z

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2024-05-15T16:06:46Z

@zzambers This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

zzambers · 2024-06-12T11:36:30Z

/open

openjdk · 2024-06-12T11:37:45Z

@zzambers This pull request is now open

bridgekeeper · 2024-07-10T12:10:38Z

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2024-08-07T16:25:32Z

@zzambers This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

satyenme · 2025-01-28T04:30:21Z

/open

openjdk · 2025-01-28T04:30:51Z

@satyenme Only the pull request author can set the pull request state to "open"

satyenme · 2025-01-28T04:35:55Z

Encountering the same test failures and would love to see this PR re-opened to support newer versions of jtreg with JDK8

zzambers · 2025-01-28T11:32:54Z

/open

openjdk · 2025-01-28T11:33:04Z

@zzambers This pull request is now open

openjdk · 2025-01-28T16:33:33Z

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

zzambers · 2025-01-28T17:04:10Z

/approval request Fixes 2 tests to work with newer jtreg, low risk, only affects test code, tested OK

openjdk · 2025-01-28T17:05:51Z

@zzambers
8265019: The approval request has been created successfully.

zzambers · 2025-01-29T11:31:08Z

/integrate

openjdk · 2025-01-29T11:32:22Z

Going to push as commit 492acd3.
Since your change was applied there have been 148 commits pushed to the master branch:

3683a81: Merge
129290d: 8339180: Enhanced Building of Processes: Follow-on Issue
c2f7e61: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
2d042cf: 8336564: Enhance mask blit functionality redux
1a447c7: 8335428: Enhanced Building of Processes
1a6e3a5: 8342822: jdk8u432-b06 does not compile on AIX
5a4b440: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
d407d63: 8345504: Bump update version of OpenJDK: 8u452
2931b1d: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F
10122b5: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
... and 138 more: https://git.openjdk.org/jdk8u-dev/compare/147b4188bc0d260a401ba383103d20cb428dbb88...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-01-29T11:32:29Z

@zzambers Pushed as commit 492acd3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Backport ffb3771816910d2eddba367812e57a9c5459ff8c

493c212

openjdk bot changed the title ~~Backport ffb3771816910d2eddba367812e57a9c5459ff8c~~ 8265019: Update tests for additional TestNG test permissions Mar 19, 2024

openjdk bot added backport rfr Pull request is ready for review labels Mar 19, 2024

bridgekeeper bot closed this May 15, 2024

openjdk bot reopened this Jun 12, 2024

bridgekeeper bot closed this Aug 7, 2024

openjdk bot reopened this Jan 28, 2025

phohensee approved these changes Jan 28, 2025

View reviewed changes

openjdk bot added approval ready Pull request is ready to be integrated labels Jan 28, 2025

openjdk bot removed the approval label Jan 29, 2025

openjdk bot added the integrated Pull request has been integrated label Jan 29, 2025

openjdk bot closed this Jan 29, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8265019: Update tests for additional TestNG test permissions #469

8265019: Update tests for additional TestNG test permissions #469

zzambers commented Mar 19, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 19, 2024

openjdk bot commented Mar 19, 2024 •

edited

Loading

openjdk bot commented Mar 19, 2024

mlbridge bot commented Mar 19, 2024

zzambers commented Mar 20, 2024

bridgekeeper bot commented Apr 17, 2024

bridgekeeper bot commented May 15, 2024

zzambers commented Jun 12, 2024

openjdk bot commented Jun 12, 2024

bridgekeeper bot commented Jul 10, 2024

bridgekeeper bot commented Aug 7, 2024

satyenme commented Jan 28, 2025

openjdk bot commented Jan 28, 2025

satyenme commented Jan 28, 2025

zzambers commented Jan 28, 2025

openjdk bot commented Jan 28, 2025

openjdk bot commented Jan 28, 2025

zzambers commented Jan 28, 2025

openjdk bot commented Jan 28, 2025

zzambers commented Jan 29, 2025

openjdk bot commented Jan 29, 2025

openjdk bot commented Jan 29, 2025

8265019: Update tests for additional TestNG test permissions #469

8265019: Update tests for additional TestNG test permissions #469

Conversation

zzambers commented Mar 19, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Mar 19, 2024

openjdk bot commented Mar 19, 2024 • edited Loading

openjdk bot commented Mar 19, 2024

mlbridge bot commented Mar 19, 2024

Webrevs

zzambers commented Mar 20, 2024

bridgekeeper bot commented Apr 17, 2024

bridgekeeper bot commented May 15, 2024

zzambers commented Jun 12, 2024

openjdk bot commented Jun 12, 2024

bridgekeeper bot commented Jul 10, 2024

bridgekeeper bot commented Aug 7, 2024

satyenme commented Jan 28, 2025

openjdk bot commented Jan 28, 2025

satyenme commented Jan 28, 2025

zzambers commented Jan 28, 2025

openjdk bot commented Jan 28, 2025

openjdk bot commented Jan 28, 2025

zzambers commented Jan 28, 2025

openjdk bot commented Jan 28, 2025

zzambers commented Jan 29, 2025

openjdk bot commented Jan 29, 2025

openjdk bot commented Jan 29, 2025

zzambers commented Mar 19, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Mar 19, 2024 •

edited

Loading