8258805: Japanese characters not entered by mouse click on Windows 10

[tkiriyama]

Hi all,
I would like to backport this bug fix (JDK-8258805) to jdk8. It is clean.
This fix depends on the fix for JDK-8212678. Since I have already created a backport pull request for JDK-8212678, it is desirable that they be integrated together.
#706

I have confirmed that the issue is resolved on Windows 11 and Windows Server 2016.
I have also confirmed that the java/awt/im and java/awt/InputMethods tests pass.

Thank you.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8258805 needs maintainer approval

Issue

• JDK-8258805: Japanese characters not entered by mouse click on Windows 10 (Bug - P3 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/716/head:pull/716
$ git checkout pull/716

Update a local copy of the PR:
$ git checkout pull/716
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/716/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 716

View PR using the GUI difftool:
$ git pr show -t 716

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/716.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into pr/706 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tkiriyama This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8258805: Japanese characters not entered by mouse click on Windows 10

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 7cca626: 8261170: Upgrade to FreeType 2.10.4
• 5452da9: 8339280: jarsigner -verify performs cross-checking between CEN and LOC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (fdcb1515)
• 01: Full - Incremental (762a0876)
• 00: Full (762a0876)

[fthevenet]

[Disclaimer: I'm not a formal reviewer for the JDK Updates project]

I had a look this PRs which, as stated above is indeed a clean backport (aside from copyright year) and according to its JBS issue, it was in fact back-ported to Oracle's 8u291 release back in 2021.
Furthermore, I have checked that the entirety of the original content for this in patch is still present "as is" in the current JDK, which presumes it's not been found to cause issues since it was introduced back in JDK 13.
I therefore feel it is safe to integrate.

Regards,
Frederic

[gnu-andrew]

I can confirm this patch is identical to the one in 11u. I'll wait for the other patch to go in and this one to be rebased against master before concluding the review.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8258805
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[gnu-andrew]

Test results look good, so happy to raise this to an approved review.

Thanks for merging.

[openjdk]

⚠️ @tkiriyama This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[tkiriyama]

Hi, @fthevenet , @gnu-andrew.
Thank you for your review! I create approval request.

[tkiriyama]

/approval request I would like to backport this bug fix(JDK-8258805) done in jdk17 to jdk8. There is no risk, as it is a clean backport except the copyright.

[openjdk]

@tkiriyama
8258805: The approval request has been created successfully.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8258805: The approval request has been approved.

[tkiriyama]

/integrate

[openjdk]

@tkiriyama
Your change (at version fdcb151) is now ready to be sponsored by a Committer.

[gnu-andrew]

/sponsor

[openjdk]

Going to push as commit 6a3f7bb.
Since your change was applied there have been 2 commits pushed to the master branch:

• 7cca626: 8261170: Upgrade to FreeType 2.10.4
• 5452da9: 8339280: jarsigner -verify performs cross-checking between CEN and LOC

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew @tkiriyama Pushed as commit 6a3f7bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.