-
Notifications
You must be signed in to change notification settings - Fork 173
8220658: Improve the readability of container information in the error log #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…r log Backport-of: 2c4b9e0778e170a17b04217bee66bb6c4fb18c0c
|
👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
jerboaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
|
|
|
Test failures seem unrelated (I'm going to look at those separately soon) /approval request low-risk, clean bar path shuffles, oracle parity, improves human diagnostic messages, eases future backport |
This (8220658) is a low-risk change which improves the readability of some debug values reported to humans. I wish to backport this to 8u partly for Oracle parity, and partly because I intend to backport 8284758, which refactors and moves most of the code introduced here to another routine.
Doing 8220658 first will ease 8284758 (reduced merge conflicts). Not doing 8220658 (and later backporting 8284758) will result in some of this code making it into 8u (the refactored bits) but not all (the improved cpu quota etc reporting)
Patch is not clean due to path differences but otherwise applied without conflicts or fuzz. Builds and smoke tests fine. I've had some trouble running tier1 locally (OOMed my workstation) so I'm going to watch for the GitHub bot results whilst I retry.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/723/head:pull/723$ git checkout pull/723Update a local copy of the PR:
$ git checkout pull/723$ git pull https://git.openjdk.org/jdk8u-dev.git pull/723/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 723View PR using the GUI difftool:
$ git pr show -t 723Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/723.diff
Using Webrev
Link to Webrev Comment