Skip to content

Conversation

@jmtd
Copy link
Contributor

@jmtd jmtd commented Nov 20, 2025

This (8220658) is a low-risk change which improves the readability of some debug values reported to humans. I wish to backport this to 8u partly for Oracle parity, and partly because I intend to backport 8284758, which refactors and moves most of the code introduced here to another routine.

Doing 8220658 first will ease 8284758 (reduced merge conflicts). Not doing 8220658 (and later backporting 8284758) will result in some of this code making it into 8u (the refactored bits) but not all (the improved cpu quota etc reporting)

Patch is not clean due to path differences but otherwise applied without conflicts or fuzz. Builds and smoke tests fine. I've had some trouble running tier1 locally (OOMed my workstation) so I'm going to watch for the GitHub bot results whilst I retry.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8220658 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8220658: Improve the readability of container information in the error log (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/723/head:pull/723
$ git checkout pull/723

Update a local copy of the PR:
$ git checkout pull/723
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/723/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 723

View PR using the GUI difftool:
$ git pr show -t 723

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/723.diff

Using Webrev

Link to Webrev Comment

…r log

Backport-of: 2c4b9e0778e170a17b04217bee66bb6c4fb18c0c
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2025

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 684fe80e4c621852af5b89f7fd3f4e227eed9ebb 8220658: Improve the readability of container information in the error log Nov 20, 2025
@openjdk
Copy link

openjdk bot commented Nov 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 20, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2025

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

⚠️ @jmtd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@jmtd
Copy link
Contributor Author

jmtd commented Nov 20, 2025

Test failures seem unrelated (I'm going to look at those separately soon)

/approval request low-risk, clean bar path shuffles, oracle parity, improves human diagnostic messages, eases future backport

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@jmtd
8220658: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants