Skip to content

Conversation

@jmtd
Copy link
Contributor

@jmtd jmtd commented Nov 21, 2025

Low risk, Oracle parity. Improves diagnostic output. Includes test modifications to cover the new diagnostics.

Included test hotspot/test/runtime/containers/docker/TestMisc.java passes for me.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313083 needs maintainer approval

Integration blocker

 ⚠️ Dependency #725 must be integrated first

Issue

  • JDK-8313083: Print 'rss' and 'cache' as part of the container information (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/726/head:pull/726
$ git checkout pull/726

Update a local copy of the PR:
$ git checkout pull/726
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 726

View PR using the GUI difftool:
$ git pr show -t 726

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/726.diff

Using Webrev

Link to Webrev Comment

Reviewed-by: andrew, sgehwolf
Backport-of: aeb2d2d0ce17da3aa7d49679beb4da2dd6f341ad
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2025

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into pr/725 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport aeb2d2d0ce17da3aa7d49679beb4da2dd6f341ad 8313083: Print 'rss' and 'cache' as part of the container information Nov 21, 2025
@openjdk
Copy link

openjdk bot commented Nov 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Nov 21, 2025
@jmtd
Copy link
Contributor Author

jmtd commented Nov 22, 2025

hotspot/test/runtime/containers/docker/TestMisc.java failing for me at the moment. Investigating... (edit: resolved)

included in error; part of context of backport but not added by
the backport.

Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
@jmtd jmtd marked this pull request as ready for review November 25, 2025 10:44
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 25, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant