-
Notifications
You must be signed in to change notification settings - Fork 551
8313556: Create implementation of NSAccessibilitySlider protocol #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3ebfc83
8313556: Create implementation of NSAccessibilitySlider protocol
azuev-java ceb83cd
Add commented out debug statements.
azuev-java 5913517
Fixing warnings during build
azuev-java ebdeb53
Merge remote-tracking branch 'origin/master' into JDK-8313556
azuev-java d890b2c
- Added accessibilityTitle method
azuev-java b35e693
Merge pull request #7 from openjdk/master
azuev-java 73bf00a
Merge remote-tracking branch 'origin/master' into JDK-8313556
azuev-java 140efce
Adding accessibilityMinValue and accessibilityMaxValue
azuev-java aa01c59
Merge pull request #10 from openjdk/master
azuev-java bee1277
Merge pull request #11 from openjdk/master
azuev-java 2376f36
Merge pull request #12 from openjdk/master
azuev-java 3e28d44
Merge pull request #13 from openjdk/master
azuev-java c122868
Merge branch 'master' into JDK-8313556
azuev-java 09f6809
Add accessibilityTitleUIElement function to the base class.
azuev-java 1ae393a
Remove duplicate code make accessibilityLabel explicitly call accessi…
azuev-java File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXSliderAccessibility.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. Oracle designates this | ||
| * particular file as subject to the "Classpath" exception as provided | ||
| * by Oracle in the LICENSE file that accompanied this code. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| #import "AccessibleBase.h" | ||
| #import <AppKit/AppKit.h> | ||
|
|
||
| @interface JFXSliderAccessibility : AccessibleBase <NSAccessibilitySlider> { | ||
|
|
||
| }; | ||
| - (NSAccessibilityRole)accessibilityRole; | ||
| - (NSString *)accessibilityLabel; | ||
| - (id)accessibilityValue; | ||
| - (BOOL)accessibilityPerformDecrement; | ||
| - (BOOL)accessibilityPerformIncrement; | ||
| @end |
73 changes: 73 additions & 0 deletions
73
modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXSliderAccessibility.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* | ||
| * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. Oracle designates this | ||
| * particular file as subject to the "Classpath" exception as provided | ||
| * by Oracle in the LICENSE file that accompanied this code. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| #import "JFXSliderAccessibility.h" | ||
|
|
||
| /* | ||
| * Implementation of the accessibility peer for the slider role | ||
| */ | ||
|
|
||
| @implementation JFXSliderAccessibility | ||
| - (NSAccessibilityRole)accessibilityRole | ||
| { | ||
| return NSAccessibilitySliderRole; | ||
| } | ||
|
|
||
| - (NSString *)accessibilityLabel | ||
| { | ||
| return [super accessibilityLabel]; | ||
| } | ||
|
|
||
| - (id)accessibilityValue | ||
| { | ||
| return [super accessibilityValue]; | ||
| } | ||
|
|
||
| - (id)accessibilityTitle | ||
| { | ||
| return [super accessibilityTitle]; | ||
| } | ||
|
|
||
| - (BOOL)accessibilityPerformIncrement | ||
| { | ||
| return [self performAccessibleAction:INCREMENT]; | ||
| } | ||
|
|
||
| - (BOOL)accessibilityPerformDecrement | ||
| { | ||
| return [self performAccessibleAction:DECREMENT]; | ||
| } | ||
|
|
||
| - (NSRect)accessibilityFrame | ||
| { | ||
| return [super accessibilityFrame]; | ||
| } | ||
|
|
||
| - (id)accessibilityParent | ||
| { | ||
| return [super accessibilityParent]; | ||
| } | ||
|
|
||
| @end |
37 changes: 37 additions & 0 deletions
37
modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXStepperAccessibility.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. Oracle designates this | ||
| * particular file as subject to the "Classpath" exception as provided | ||
| * by Oracle in the LICENSE file that accompanied this code. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| #import "AccessibleBase.h" | ||
| #import <AppKit/AppKit.h> | ||
|
|
||
| @interface JFXStepperAccessibility : AccessibleBase <NSAccessibilityStepper> { | ||
|
|
||
| }; | ||
| - (NSAccessibilityRole)accessibilityRole; | ||
| - (NSString *)accessibilityLabel; | ||
| - (id)accessibilityValue; | ||
| - (BOOL)accessibilityPerformDecrement; | ||
| - (BOOL)accessibilityPerformIncrement; | ||
| @end |
78 changes: 78 additions & 0 deletions
78
modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXStepperAccessibility.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /* | ||
| * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. Oracle designates this | ||
| * particular file as subject to the "Classpath" exception as provided | ||
| * by Oracle in the LICENSE file that accompanied this code. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| #import "JFXStepperAccessibility.h" | ||
|
|
||
| /* | ||
| * Implementation of the accessibility peer for the stepper role | ||
| */ | ||
|
|
||
| @implementation JFXStepperAccessibility | ||
| - (NSAccessibilityRole)accessibilityRole | ||
| { | ||
| return NSAccessibilityIncrementorRole; | ||
| } | ||
|
|
||
| - (NSString *)accessibilityLabel | ||
| { | ||
| return [super accessibilityLabel]; | ||
| } | ||
|
|
||
| - (id)accessibilityValue | ||
| { | ||
| return [super accessibilityValue]; | ||
| } | ||
|
|
||
| - (id)accessibilityMinValue | ||
| { | ||
| return [super accessibilityMinValue]; | ||
| } | ||
|
|
||
| - (id)accessibilityMaxValue | ||
| { | ||
| return [super accessibilityMaxValue]; | ||
| } | ||
|
|
||
| - (BOOL)accessibilityPerformIncrement | ||
| { | ||
| return [self performAccessibleAction:INCREMENT]; | ||
| } | ||
|
|
||
| - (BOOL)accessibilityPerformDecrement | ||
| { | ||
| return [self performAccessibleAction:DECREMENT]; | ||
| } | ||
|
|
||
| - (NSRect)accessibilityFrame | ||
| { | ||
| return [super accessibilityFrame]; | ||
| } | ||
|
|
||
| - (id)accessibilityParent | ||
| { | ||
| return [super accessibilityParent]; | ||
| } | ||
|
|
||
| @end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is same as
accessibilityLabel. Should we change implementation to call one method from the other ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.