Skip to content

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented Dec 10, 2024

This PR enables several previously disabled test cases for Wayland, as the required fixes are already in the promoted build. (JDK-8335469, JDK-8335468)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8335470: [XWayland] JavaFX tests that use AWT Robot fail on Wayland (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1661/head:pull/1661
$ git checkout pull/1661

Update a local copy of the PR:
$ git checkout pull/1661
$ git pull https://git.openjdk.org/jfx.git pull/1661/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1661

View PR using the GUI difftool:
$ git pr show -t 1661

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1661.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2024

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2024

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335470: [XWayland] JavaFX tests that use AWT Robot fail on Wayland

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@azvegint azvegint marked this pull request as ready for review December 10, 2024 16:23
@openjdk openjdk bot added the rfr Ready for review label Dec 10, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2024

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Ready to be integrated label Dec 11, 2024
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

Going to push as commit b76c05b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2024
@openjdk openjdk bot closed this Dec 11, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Dec 11, 2024
@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@azvegint Pushed as commit b76c05b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants