-
Notifications
You must be signed in to change notification settings - Fork 200
7801: Fix GHA that is broken due to OpenJDK Update 11.0.15 #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
|
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@RealCLanger |
|
/sponsor |
|
@thegreystone @RealCLanger Pushed as commit 64aa2ae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
OpenJDK 11.0.15 has introduced a regression that breaks the JMC build on Windows (with JDK-8278356). It will be fixed in OpenJDK 11.0.16 with JDK-8285445.
For now we can workaround the problem by pinning to OpenJDK 11.0.14 in the GHA workflow which should be fine from a security perspective.
I also experimented with adding
-Djdk.io.File.enableADS=truewhich is what JDK-8285445 effectively does but to no avail.The change updates to actions/setup-java@v2 and sets the JDK distribution in use to Temurin.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/402/head:pull/402$ git checkout pull/402Update a local copy of the PR:
$ git checkout pull/402$ git pull https://git.openjdk.java.net/jmc pull/402/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 402View PR using the GUI difftool:
$ git pr show -t 402Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/402.diff