Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7801: Fix GHA that is broken due to OpenJDK Update 11.0.15 #402

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Collaborator

@RealCLanger RealCLanger commented May 19, 2022

OpenJDK 11.0.15 has introduced a regression that breaks the JMC build on Windows (with JDK-8278356). It will be fixed in OpenJDK 11.0.16 with JDK-8285445.

For now we can workaround the problem by pinning to OpenJDK 11.0.14 in the GHA workflow which should be fine from a security perspective.

I also experimented with adding -Djdk.io.File.enableADS=true which is what JDK-8285445 effectively does but to no avail.

The change updates to actions/setup-java@v2 and sets the JDK distribution in use to Temurin.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 committer)

Issue

  • JMC-7801: Fix GHA that is broken due to OpenJDK Update 11.0.15

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/402/head:pull/402
$ git checkout pull/402

Update a local copy of the PR:
$ git checkout pull/402
$ git pull https://git.openjdk.java.net/jmc pull/402/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 402

View PR using the GUI difftool:
$ git pr show -t 402

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/402.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JMC-7801 7801: Fix GHA that is broken due to OpenJDK Update 11.0.15 May 19, 2022
@openjdk openjdk bot added the rfr label May 19, 2022
@mlbridge
Copy link

mlbridge bot commented May 19, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 19, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7801: Fix GHA that is broken due to OpenJDK Update 11.0.15

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 578b500: 7794: Update the link to the adoptium download site

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label May 19, 2022
@RealCLanger
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot added the sponsor label May 19, 2022
@openjdk
Copy link

openjdk bot commented May 19, 2022

@RealCLanger
Your change (at version a28fe88) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 19, 2022

Going to push as commit 64aa2ae.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 578b500: 7794: Update the link to the adoptium download site

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented May 19, 2022

@thegreystone @RealCLanger Pushed as commit 64aa2ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the fix-gha-windows branch May 19, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants