#68 Automatically compile project before execute javafx:jlink goal, if needed #69
Conversation
|
|
||
| String outputDirectory = project.getBuild().getOutputDirectory(); | ||
| if (outputDirectory == null || outputDirectory.isEmpty()) { | ||
| throw new MojoExecutionException("Output directory doesn't exist, compile first"); |
There was a problem hiding this comment.
In theory, the compiler plugin will do its job, and target shouldn't be null. However this is a sanity check to prevent any possible situation where target is removed even after compile creates it? Maybe we can rephrase the message instead?
There was a problem hiding this comment.
Agree.
What do you think of this message: "Output directory doesn't exist after compile"
There was a problem hiding this comment.
I would just say "Error: Output directory doesn't exist"
| getLog().debug("Output directory was empty, compiling..."); | ||
| classes = new File(outputDirectory).listFiles(); | ||
| if (classes == null || classes.length == 0) { |
There was a problem hiding this comment.
remove these three lines only
| getLog().debug("Output directory was empty, compiling..."); | ||
| classes = new File(outputDirectory).listFiles(); | ||
| if (classes == null || classes.length == 0) { | ||
| throw new MojoExecutionException("Output directory is empty, compile first"); |
There was a problem hiding this comment.
keep the exception, rephrasing the message, to prevent a possible NPE if classes is null or empty.
| } else { | ||
| // TODO: verify if classes require compiling | ||
| } |
There was a problem hiding this comment.
This can be safely removed
3 participants
Compilation is carried out through the Maven compile phase instead the goal compiler:compile. Because of this, any goal associated with said phase will also be executed.
Fixes #68