Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
There was a problem hiding this comment.
This PR introduces critical compilation-breaking bugs: new() is being used with values (composite literals and string literals) instead of types, which is invalid Go. The root cause is a misunderstanding of how //go:fix inline works and what new accepts — all call sites replacing ptr.PointTo(x) with new(x) must instead use &x (address-of expression). The ptr.go function body must also be reverted to return &t.
PR Bot Information
Version: 1.17.91 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
- Event Trigger:
pull_request.opened - Correlation ID:
b8335eb0-18a9-11f1-99a4-c7cf4e5bf58c - LLM:
anthropic--claude-4.6-sonnet
davidbolet
pushed a commit
to davidbolet/keystore-plugins
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Apply Lint Tool Required Updates
Chore
🔧 Applied code style and correctness fixes required by the
golangci-linttool. Changes enforce modern Go idioms, pin tooling versions for reproducible builds, and remove unnecessary indirection patterns.Changes
.github/workflows/ci.yaml: Addedpull-requests: writepermission to the CI workflow.Makefile: Pinnedgolangci-lintinstallation tov2.9.0instead of@latestfor reproducible builds.go.mod: Bumped minimum Go version from1.25.4to1.25.6.internal/utils/ptr/ptr.go: Changed return expression from&tto&(t)to satisfy linter requirements.internal/plugins/keystoreop/aws/operations.go: Removed unusedptrpackage import; replaced allptr.PointTo(...)calls with direct struct literal pointer syntax (&operationsv1.ValidateKeyResponse{...}).internal/plugins/keystoreop/aws/auth_test.go: Removed unusedptrimport; replacedmap[string]interface{}withmap[string]anythroughout test cases.internal/plugins/keystoreop/aws/client_test.go: Replaced allmap[string]interface{}withmap[string]any.internal/plugins/keystoreop/aws/operations_test.go: Replacedmap[string]interface{}withmap[string]any.internal/plugins/keystoreop/base/access_data_test.go: Replacedmap[string]interface{}withmap[string]any.internal/common/structreader_test.go: Replaced allmap[string]interface{}withmap[string]any.internal/utils/must/must_test.go: Replacedinterface{}withanyin test struct field definition.📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!
PR Bot Information
Version:
1.17.91| 📖 Documentation | 🚨 Create Incident | 💬 Feedbackpull_request.editedd58f5ce0-18ac-11f1-92b5-c246bac720e5anthropic--claude-4.6-sonnet