Skip to content

fix: updates required by lint tool#88

Merged
nnicora merged 4 commits intomainfrom
fix/lints
Mar 5, 2026
Merged

fix: updates required by lint tool#88
nnicora merged 4 commits intomainfrom
fix/lints

Conversation

@nnicora
Copy link
Copy Markdown
Contributor

@nnicora nnicora commented Mar 5, 2026

Fix: Apply Lint Tool Required Updates

Chore

🔧 Applied code style and correctness fixes required by the golangci-lint tool. Changes enforce modern Go idioms, pin tooling versions for reproducible builds, and remove unnecessary indirection patterns.

Changes

  • .github/workflows/ci.yaml: Added pull-requests: write permission to the CI workflow.
  • Makefile: Pinned golangci-lint installation to v2.9.0 instead of @latest for reproducible builds.
  • go.mod: Bumped minimum Go version from 1.25.4 to 1.25.6.
  • internal/utils/ptr/ptr.go: Changed return expression from &t to &(t) to satisfy linter requirements.
  • internal/plugins/keystoreop/aws/operations.go: Removed unused ptr package import; replaced all ptr.PointTo(...) calls with direct struct literal pointer syntax (&operationsv1.ValidateKeyResponse{...}).
  • internal/plugins/keystoreop/aws/auth_test.go: Removed unused ptr import; replaced map[string]interface{} with map[string]any throughout test cases.
  • internal/plugins/keystoreop/aws/client_test.go: Replaced all map[string]interface{} with map[string]any.
  • internal/plugins/keystoreop/aws/operations_test.go: Replaced map[string]interface{} with map[string]any.
  • internal/plugins/keystoreop/base/access_data_test.go: Replaced map[string]interface{} with map[string]any.
  • internal/common/structreader_test.go: Replaced all map[string]interface{} with map[string]any.
  • internal/utils/must/must_test.go: Replaced interface{} with any in test struct field definition.
  • 🔄 Regenerate and Update Summary

📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

PR Bot Information

Version: 1.17.91 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Summary Prompt: Default Prompt
  • Event Trigger: pull_request.edited
  • Correlation ID: d58f5ce0-18ac-11f1-92b5-c246bac720e5
  • LLM: anthropic--claude-4.6-sonnet
  • Output Template: Default Template

@push-tags-from-workflow push-tags-from-workflow Bot added bug Something isn't working dependencies Pull requests that update a dependency file tests dev-ops labels Mar 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 5, 2026, 4:01 PM

Copy link
Copy Markdown

@hyperspace-insights hyperspace-insights Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces critical compilation-breaking bugs: new() is being used with values (composite literals and string literals) instead of types, which is invalid Go. The root cause is a misunderstanding of how //go:fix inline works and what new accepts — all call sites replacing ptr.PointTo(x) with new(x) must instead use &x (address-of expression). The ptr.go function body must also be reverted to return &t.

PR Bot Information

Version: 1.17.91 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Event Trigger: pull_request.opened
  • Correlation ID: b8335eb0-18a9-11f1-99a4-c7cf4e5bf58c
  • LLM: anthropic--claude-4.6-sonnet

Comment thread internal/utils/ptr/ptr.go Outdated
Comment thread internal/plugins/keystoreop/aws/operations.go Outdated
Comment thread internal/plugins/keystoreop/aws/operations.go Outdated
Comment thread internal/plugins/keystoreop/aws/operations.go Outdated
Comment thread internal/plugins/keystoreop/aws/operations.go Outdated
Comment thread internal/plugins/keystoreop/aws/operations.go Outdated
Comment thread internal/plugins/keystoreop/aws/operations.go Outdated
Comment thread internal/plugins/keystoreop/aws/operations.go Outdated
Comment thread internal/plugins/keystoreop/aws/auth_test.go Outdated
@nnicora nnicora merged commit b8cc65a into main Mar 5, 2026
6 checks passed
@nnicora nnicora deleted the fix/lints branch March 5, 2026 16:06
davidbolet pushed a commit to davidbolet/keystore-plugins that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci-cd dependencies Pull requests that update a dependency file dev-ops tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant