Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Contributor
There was a problem hiding this comment.
The pull request contains a critical logic error in the fix: the second condition compares builtin.Name() against pluginConfig.Type (a name vs. a type), which will never be true in normal usage, meaning no built-in plugin will ever be found. The correct fix requires comparing builtin.Type() against pluginConfig.Type, as noted in the review comment.
PR Bot Information
Version: 1.17.91 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
- LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
5f58b890-187b-11f1-8d4a-0c0d57366279 - Event Trigger:
pull_request.opened
nnicora
approved these changes
Mar 5, 2026
This was referenced Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Built-in Plugin Override on Name and Type Collision
Bug Fix
🐛 Resolved an issue where two built-in plugins of different types but with the same name would cause the
loadPluginAsBuiltInfunction to incorrectly match and use the first plugin's implementation, leading to inconsistent behavior.Changes
pkg/catalog/catalog.go: Updated the matching condition inloadPluginAsBuiltInto require bothbuiltin.Name() == pluginConfig.Nameandbuiltin.Name() == pluginConfig.Type, ensuring that a built-in plugin is only selected when both the name and type match — preventing false matches across plugins of different types that share the same name.📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!
PR Bot Information
Version:
1.17.91| 📖 Documentation | 🚨 Create Incident | 💬 Feedback80661740-1884-11f1-9178-53854736be74issue_comment.edited