Skip to content

feat: update keystore role#163

Merged
doanhluongsap merged 1 commit into
mainfrom
task/update-keystore-role
Jul 2, 2026
Merged

feat: update keystore role#163
doanhluongsap merged 1 commit into
mainfrom
task/update-keystore-role

Conversation

@doanhluongsap

@doanhluongsap doanhluongsap commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

- Add grant trust type to the grant trust request

Special notes for your reviewer:

Release note:

@doanhluongsap doanhluongsap self-assigned this Jul 1, 2026
@coderabbitai

coderabbitai Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dbdeac23-1a48-4feb-84fd-563b9758b380

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@doanhluongsap doanhluongsap requested a review from minh-nghia July 1, 2026 09:44
@github-actions

github-actions Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJul 1, 2026, 9:56 AM

@doanhluongsap doanhluongsap requested a review from niazkhansap July 1, 2026 09:45
minh-nghia
minh-nghia reviewed Jul 1, 2026
View reviewed changes
Comment thread proto/plugin/keystore/management/v1/management.proto Outdated
message DeleteKeystoreResponse {}

// GrantTrustType specifies whether a management or crypto role should be created.
enum GrantTrustType {

@minh-nghia minh-nghia Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Np: TrustType or RoleType may be sufficient IMO

@doanhluongsap doanhluongsap force-pushed the task/update-keystore-role branch 2 times, most recently from 8635015 to 17a3c52 Compare July 1, 2026 09:53
@doanhluongsap
feat: update keystore role
d0fb245 
Signed-off-by: Doanh Luong <doanh.luong@sap.com>
@doanhluongsap doanhluongsap force-pushed the task/update-keystore-role branch from 17a3c52 to d0fb245 Compare July 1, 2026 09:56
@doanhluongsap doanhluongsap merged commit 48b567f into main Jul 2, 2026
10 checks passed
@doanhluongsap doanhluongsap deleted the task/update-keystore-role branch July 2, 2026 08:15
@push-tags-from-workflow push-tags-from-workflow Bot mentioned this pull request Jul 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minh-nghia minh-nghia minh-nghia approved these changes
@niazkhansap niazkhansap niazkhansap approved these changes

Assignees

@doanhluongsap doanhluongsap

Labels

api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doanhluongsap @minh-nghia @niazkhansap