feat: add common keystore plugin errors#56
Merged
minh-nghia merged 1 commit intoopenkcm:mainfrom Sep 3, 2025
Merged
Conversation
minh-nghia
requested review from
MarkMcAleese,
doanhluongsap and
petersbingham
minh-nghia
force-pushed
the
feat/keystore-plugin-errors
branch
from
95d3e48 to
1b5c136
Compare
| ) | ||
|
|
||
| var ( | ||
| StatusProviderAuthenticationError = status.New( |
Contributor
There was a problem hiding this comment.
Do we raise these in the interface (I guess not)? Problem is that there is nothing to oblige the implementer to use these but I'm inferring that's there's now a reliance for them from CMK.
Contributor
Author
There was a problem hiding this comment.
Yea, not really anything to force such errors to be used
Contributor
Author
There was a problem hiding this comment.
Added to function descriptions
MarkMcAleese
approved these changes
Sep 3, 2025
doanhluongsap
approved these changes
Sep 3, 2025
minh-nghia
force-pushed
the
feat/keystore-plugin-errors
branch
from
1b5c136 to
a6258a1
Compare
|
This was referenced Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add gRPC error definitions with detailed reason that can be used by both keystore plugins and CMK
Release note:
NONE