Skip to content

Conversation

@gberaudo
Copy link
Member

@gberaudo gberaudo commented Dec 1, 2014

Add a function to warmup Cesium. It is essential to get smoother transition from 2D to 3D.

By pre-loading Cesium, it allows a faster switch to 3D.
The camera will be positioned using the provided height
and the 2D coordinates from the ol3 view.
gberaudo added a commit that referenced this pull request Dec 2, 2014
@gberaudo gberaudo merged commit 28b641d into openlayers:master Dec 2, 2014
@ahocevar
Copy link
Member

ahocevar commented Dec 2, 2014

Based on whose review did you merge this? The code is ok, but not the coding style. In ol3, we discourage truthy && doSomething() in favor of if (truthy) { doSomething(); }.

@gberaudo
Copy link
Member Author

gberaudo commented Dec 2, 2014

Hi @ahocevar, sorry I thought you were not interested in reviewing the
rest of the commits. Please add post-merge comments.

@schmidtk
Copy link
Contributor

schmidtk commented Dec 4, 2014

I'd also suggest using goog.bind(function() { ... }, this) over var that = this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants