Skip to content

Remove duplicated style parameter #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elemoine merged 1 commit into from
Nov 16, 2014
Merged

Remove duplicated style parameter #2896

elemoine merged 1 commit into from
Nov 16, 2014

Conversation

@kalinbas
Copy link
Contributor

@kalinbas kalinbas commented Oct 30, 2014

  • "duplicated" style parameter is not supported by Intergraph GeoMedia
  • Uppercase Parameter is needed by ARCGis
  • are there other constraints?

@kalinbas
Update wmtssource.js
08c6e60 
- "duplicated" style parameter is not supported by Intergraph GeoMedia
- Uppercase Parameter is needed by ARCGis 
- are there other constraints?
@kalinbas kalinbas changed the title Update wmtssource.js Remove duplicated style parameter Oct 30, 2014
@fredj fredj added this to the v3.1.0 milestone Oct 30, 2014
@elemoine elemoine changed the title Remove duplicated style parameter Remove duplicated style parameter Nov 8, 2014
@tschaub
Copy link
Member

tschaub commented Nov 11, 2014

Too bad 7fec1f5 didn't include more information on why the style parameter was added (like which server required it).

The spec says this about parameter names in GetTile requests:

All parameter names are here listed using mostly lower case letters. However, any parameter
name capitalization SHALL be allowed in KVP encoding, see subclause 11.5.2 of OWS Common
[OGC 06-121r3].

(From table 29 on page 51 of the 1.0 spec.)

@elemoine
Copy link
Member

elemoine commented Nov 11, 2014

The commit mentions ArcGIS.

@elemoine elemoine closed this Nov 11, 2014
@elemoine elemoine reopened this Nov 11, 2014
@tschaub
Copy link
Member

tschaub commented Nov 11, 2014

The commit mentions ArcGIS.

Unclear comment on my part. That commit doesn't mention why style is left in (only why Style is added). I mainly wanted to point out that the spec does say that case is not significant. It sounds like ArcGIS WMTS doesn't comply (requiring Style). I imagine there could be other non-compliant servers as well (perhaps requiring style).

That said, I don't have a problem merging this.

elemoine pushed a commit that referenced this pull request Nov 16, 2014
Merge pull request #2896 from kalinbas/patch-1
3bf4cf2 
Remove duplicated style parameter
@elemoine elemoine merged commit 3bf4cf2 into openlayers:master Nov 16, 2014
@kalinbas kalinbas deleted the patch-1 branch December 2, 2014 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kalinbas @tschaub @elemoine @fredj