Add ol-touch but keep ol-viewport className. #3775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
Member
|
Looks good to me too. |
pgiraud
pushed a commit
that referenced
this pull request
Jun 9, 2015
Add ol-touch but keep ol-viewport className.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when displaying a map on a touch device the
ol-touchclassName is added to the viewport. Well this className actually replacesol-viewport.In my application I rely on
ol-viewportto add styling behavior to element within the viewport and I don't want to add specific css selectors for touch devices.With this pull request
ol-touchis effectively added instead of replacing the existing one.I've tested manually some examples and haven't seen any weird behavior.
Please review.