Prevent null array to be passed to an ol.Collection

[fredj]

The compiler should be able to detect that:

var collection = new ol.Collection(null);

or:

collection.extend(null);

are invalid

[elemoine]

Any specific reasons for removing the types here? Note that these were not typecasts.

[elemoine]

LGTM. Just wondering about the removal of types in the select interaction.

[fredj]

Without these types removal, the compiler considers that {Array.<ol.Feature>} may be null and returns an error:

ERR! compile found   : (Array<(null|ol.Feature)>|null)
ERR! compile required: Array<(null|ol.Feature)>
ERR! compile     features.extend(selected);
ERR! compile                     ^
ERR! compile 

[fredj]

Instead of removing the type, I'll change it to {!Array.<ol.Feature>}

[elemoine]

Instead of removing the type, I'll change it to {!Array.<ol.Feature>}

Yes, I was going to suggest the same.

[fredj]

Thanks for the review