Style source control links in examples #3984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I like the new look better, Tim. Please merge once the checks are green. |
Member
Author
|
Hmm. Firefox isn't letting Zero Clipboard do its thing with this |
Member
Author
Disregard that. Flash disabled in Firefox. Same behavior on master. |
tschaub
added a commit
that referenced
this pull request
Aug 7, 2015
Style source control links in examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the two blue buttons for copy & edit in favor of more subtle links.
Regarding the use of Font Awesome, I think it makes sense in this context. I don't think it makes sense to have the example content rely on things like Bootstrap and Font Awesome. I'd like to update things so you don't need Bootstrap and all the
container-fluid,row-fluid, etc. just to reproduce these examples. But that can happen separately.