Remove unnecessary cast #4222
Merged
Remove unnecessary cast #4222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externs/olx.js
Outdated
Member
There was a problem hiding this comment.
No, we were discussing getting rid of this and changing the way attributions work. Should not be @api.
Member
|
Please merge when Travis is happy, but add a ticket description to provide some context (like why these changes were made). |
Member
Author
|
|
Member
Was going to suggest to not add it again, but didn't want to bother you too much. But now that you're at it already, please remove that commit from the pull request. |
Member
Author
|
Thanks for the review @ahocevar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unneeded cast found by the closure-compiler (
unnecessaryCastsoption).