Add target property to Drag&Drop interaction
#4876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I like it, and it looks good. Please merge. |
externs/olx.js
Outdated
| /** | ||
| * @typedef {{formatConstructors: (Array.<function(new: ol.format.Feature)>|undefined), | ||
| * projection: ol.proj.ProjectionLike}} | ||
| * projection: ol.proj.ProjectionLike, target: (Element|undefined)}} |
Member
|
+1 |
tsauerwein
force-pushed
the
drag-n-drop-target
branch
from
adcab0d to
d205dfc
Compare
tsauerwein
force-pushed
the
drag-n-drop-target
branch
from
0a798f2 to
1e8bbb0
Compare
tsauerwein
pushed a commit
that referenced
this pull request
Feb 22, 2016
Add `target` property to Drag&Drop interaction
Member
Author
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add a
targetproperty to the drag&drop interaction. Currently the drop-zone of the interaction is always the viewport element, which makes it a bit difficult to style the drop-zone The proposedtargetproperty would make the interaction more flexible. E.g. the drop-zone could be outside the map, the whole document, ...