Add CartoDB tile source. #4926
Merged
Add CartoDB tile source. #4926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externs/olx.js
Outdated
| * minZoom: (number|undefined), | ||
| * wrapX: (boolean|undefined), | ||
| * config: (Object|undefined), | ||
| * map: string, |
Member
There was a problem hiding this comment.
It looks like maybe this should be (string|undefined) based on your example use.
Member
|
Hey @aisaacs - I just wanted to say I like this pull request, and I'm hoping you find time to finish it. |
aisaacs
force-pushed
the
cartodb
branch
2 times, most recently
from
01e333b to
0e5749b
Compare
src/ol/source/cartodb.js
Outdated
| goog.provide('ol.source.CartoDB'); | ||
|
|
||
| goog.require('goog.asserts'); | ||
| goog.require('ol.source.State') |
Member
There was a problem hiding this comment.
Looks like a missing semicolon. (We could make the linter warn here so we're not left with confusing build errors.)
aisaacs
force-pushed
the
cartodb
branch
3 times, most recently
from
9a728ea to
a8c85b6
Compare
Member
|
Looks great @aisaacs. Thanks for sticking with it. It will be nice to see this get some additional use. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. It adds a carto db source that supports both named and anonymous maps.
I've been sitting on this for a while, which is why it still uses
goog.net. I plan on removing that and replacing it with straightXMLHttpRequest.