Remove ol.raster namespace #5399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now used only for 1 typedefs and 1 enum, it serves little purpose, so the typedef is renamed in the ol namespace, and the enum moved to rastersource.js
Contributor
Author
|
now rebased to account for #5427. As |
Member
|
Thanks @probins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next and penultimate part of typedef move.
The namespace is only used currently for 2 typedefs and 1 enum, so it serves little purpose.
So the 2 typedefs are renamed in the ol namespace, and the enum moved to rastersource.js
@ahocevar if this looks familiar, it's much as you proposed in a096c3d. The main difference is that you renamed the enum to
ol.source.RasterOperationType. I preferol.RasterOperationTypeso it's consistent withol.RasterOperation. And in any case, the sub-namespaces will be disappearing as part of conversion to modules.I generated apidocs, and the refs all look ok.